Details
Details
- On web make sure that on each refresh device token is set
- On native make sure that on app open device token is set, on logout remains the same
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- device-token
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
lib/reducers/tunnelbroker-device-token-reducer.js | ||
---|---|---|
12–14 ↗ | (On Diff #41810) | This pattern is confusing to me... in which cases do we expect action.payload to not be set? Is there a clearer way to differentiate between these two cases, eg. something like: type SetDeviceTokenStartedPayload = | { +type: 'nothing_to_set' } | { +type: 'optimistically_set_device_token', +deviceToken: string } | { +type: 'clear_device_token' }; |
native/push/push-handler.react.js | ||
536 ↗ | (On Diff #41810) |