[web] introduce TagFarcasterChannelModal
ClosedPublic
Actions

Authored by ginsu on Jun 21 2024, 3:16 AM.

Details

Reviewers

inka
ashoat
kamil

Commits

rCOMM084003ee186f: [web] introduce TagFarcasterChannelModal

Summary

This diff introduces the TagFarcasterChannelModal component. This modal will show the selected farcaster channel if there is one tag otherwise it will let the user create a tag. Subsequent diffs in this stack will extend this modal

Test Plan

Please see the screenshot below

w/ tagged channel

Screenshot 2024-06-20 at 11.18.48 PM.png (2×3 px, 801 KB)

w/o tagged channel

Screenshot 2024-06-20 at 11.17.36 PM.png (2×3 px, 895 KB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Jun 21 2024, 3:16 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 21 2024, 3:16 AM

copy review

web/tag-farcaster-channel/tag-farcaster-channel-modal.react.js
43 ↗	(On Diff #41588)	This copy is taken from here, but still want to get the green light from @ashoat https://github.com/CommE2E/comm/blob/master/native/community-settings/tag-farcaster-channel/tag-farcaster-channel.react.js#L87

update

ginsu added inline comments.Jun 21 2024, 3:28 AM

web/tag-farcaster-channel/tag-farcaster-channel-modal.react.js
28 ↗	(On Diff #41589)	This copy is taken from here, but still want to get the green light from @ashoat https://github.com/CommE2E/comm/blob/master/native/community-settings/tag-farcaster-channel/tag-farcaster-channel.react.js#L53
41 ↗	(On Diff #41589)	This copy is taken from here, but still want to get the green light from @ashoat https://github.com/CommE2E/comm/blob/master/native/community-settings/tag-farcaster-channel/tag-farcaster-channel-navigator.react.js#L55
43 ↗	(On Diff #41589)	This copy is taken from here, but still want to get the green light from @ashoat https://github.com/CommE2E/comm/blob/master/native/community-settings/tag-farcaster-channel/tag-farcaster-channel.react.js#L87
45 ↗	(On Diff #41589)	This copy is taken from here, but still want to get the green light from @ashoat https://github.com/CommE2E/comm/blob/master/native/community-settings/tag-farcaster-channel/tag-farcaster-channel.react.js#L92