[lib/native] introduce useRemoveFarcasterChannelTag
ClosedPublic
Actions

Authored by ginsu on Jun 20 2024, 8:30 PM.

Details

Reviewers

kamil
inka

Commits

rCOMMd58a4b0c065e: [lib/native] introduce useRemoveFarcasterChannelTag

Summary

We are going to want this logic on both web and native. Created this shared hook that factors out all the shared logic for removing a farcaster channel tag

Test Plan

flow + confirmed no regressions with removing a farcaster channel tag on native

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Jun 20 2024, 8:30 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 20 2024, 8:30 PM

ginsu edited the summary of this revision. (Show Details)Jun 20 2024, 8:31 PM

ginsu added reviewers: kamil, inka.

ginsu added a parent revision: D12530: [web] introduce TagFarcasterChannelModal.

ginsu added a child revision: D12533: [native] fix button container height in RemoveTagButton.Jun 20 2024, 8:34 PM

Harbormaster completed remote builds in B29856: Diff 41591.Jun 20 2024, 8:46 PM

ginsu requested review of this revision.Jun 20 2024, 8:46 PM

inka accepted this revision.Jun 21 2024, 12:56 AM

inka added inline comments.

lib/shared/community-utils.js
22 ↗	(On Diff #41591)	I think we can call it just `communityID`

This revision is now accepted and ready to land.Jun 21 2024, 12:56 AM

ginsu added inline comments.Jun 21 2024, 11:17 AM

lib/shared/community-utils.js
22 ↗	(On Diff #41591)	I use `commCommunityID` in a lot of other places where the I do farcaster channel tagging logic + a feel like this makes it super clear that this is from comm and not farcaster