Page MenuHomePhabricator

[lib/native] introduce useRemoveFarcasterChannelTag
ClosedPublic

Authored by ginsu on Jun 20 2024, 8:30 PM.
Tags
None
Referenced Files
F3372597: D12532.diff
Tue, Nov 26, 7:13 AM
Unknown Object (File)
Sat, Nov 16, 1:25 PM
Unknown Object (File)
Sat, Nov 16, 12:36 PM
Unknown Object (File)
Sat, Nov 16, 11:31 AM
Unknown Object (File)
Sat, Nov 16, 10:48 AM
Unknown Object (File)
Fri, Nov 15, 11:25 PM
Unknown Object (File)
Fri, Nov 15, 10:24 AM
Unknown Object (File)
Sun, Nov 10, 3:11 AM
Subscribers

Details

Summary

We are going to want this logic on both web and native. Created this shared hook that factors out all the shared logic for removing a farcaster channel tag

Test Plan

flow + confirmed no regressions with removing a farcaster channel tag on native

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu requested review of this revision.Jun 20 2024, 8:46 PM
inka added inline comments.
lib/shared/community-utils.js
22 ↗(On Diff #41591)

I think we can call it just communityID

This revision is now accepted and ready to land.Jun 21 2024, 12:56 AM
lib/shared/community-utils.js
22 ↗(On Diff #41591)

I use commCommunityID in a lot of other places where the I do farcaster channel tagging logic + a feel like this makes it super clear that this is from comm and not farcaster

Removed from stack so I can land as is. Confirmed that this is safe + does not cause any merge conflicts when rebasing

ginsu edited the summary of this revision. (Show Details)

rebase before landing

This revision was landed with ongoing or failed builds.Jun 21 2024, 11:20 AM
This revision was automatically updated to reflect the committed changes.