Page MenuHomePhabricator
Differential D12533

[native] fix button container height in RemoveTagButton
ClosedPublic
Actions

Authored by ginsu on Jun 20 2024, 8:33 PM.
Tags
None
Referenced Files
F2835683: D12533.diff
Sat, Sep 28, 2:24 PM
Unknown Object (File)
Sat, Sep 14, 3:11 AM
Unknown Object (File)
Sat, Sep 14, 3:11 AM
Unknown Object (File)
Sat, Sep 14, 3:11 AM
Unknown Object (File)
Sat, Sep 14, 3:11 AM
Unknown Object (File)
Sat, Sep 14, 3:11 AM
Unknown Object (File)
Tue, Sep 10, 7:24 AM
Unknown Object (File)
Aug 19 2024, 5:14 PM
View All 38 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
inka
Commits
rCOMMf772adbc5483: [native] fix button container height in RemoveTagButton
Summary

As I was factoring out logic for the remove tag button, noticed a small issue where the button was slightly shifting the height of the panel a few pixels when the content was going from "Remove tag" to the loading spinner. We should set the height of the button container so that this does not happen

Depends on D12532

Test Plan

Confirmed that the height of the button container remained the same when switching between loading and non-loading state

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Jun 20 2024, 8:33 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 20 2024, 8:33 PM
ginsu edited the summary of this revision. (Show Details)Jun 20 2024, 8:34 PM
ginsu added reviewers: kamil, inka.
ginsu added a parent revision: D12532: [lib/native] introduce useRemoveFarcasterChannelTag.
ginsu added inline comments.
native/community-settings/tag-farcaster-channel/remove-tag-button.react.js
42 ↗(On Diff #41592)

TagChannelButton does the same

https://github.com/CommE2E/comm/blob/master/native/community-settings/tag-farcaster-channel/tag-channel-button.react.js#L187

62 ↗(On Diff #41592)

Already introduced the style here just forgot to call it smh

Harbormaster completed remote builds in B29857: Diff 41592.Jun 20 2024, 8:49 PM
ginsu requested review of this revision.Jun 20 2024, 8:49 PM
inka accepted this revision.Jun 21 2024, 12:57 AM
This revision is now accepted and ready to land.Jun 21 2024, 12:57 AM
ginsu updated this revision to Diff 41615.Jun 21 2024, 11:18 AM

rebase before landing

This revision was landed with ongoing or failed builds.Jun 21 2024, 11:20 AM
Closed by commit rCOMMf772adbc5483: [native] fix button container height in RemoveTagButton (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMf772adbc5483: [native] fix button container height in RemoveTagButton.
Harbormaster completed remote builds in B29875: Diff 41615.Jun 21 2024, 11:35 AM

Revision Contents
Changeset List

PathSize
native/
community-settings/
tag-farcaster-channel/
4 lines

Diff 41615

View Options

native/community-settings/tag-farcaster-channel/remove-tag-button.react.js

Loading...