Differential D12547

remove reserved wallet registration RPC
ClosedPublic
Actions

Authored by varun on Jun 21 2024, 4:48 PM.

Details

Reviewers

bartek

Commits

rCOMM54a1ca0f14e0: remove reserved wallet registration RPC

Summary

we don't need this. SIWE is enough to prove that a user owns a particular wallet address

Depends on D12546

Test Plan

everything builds, git grep'd for any remaining references to this RPC and message type

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Jun 21 2024, 4:48 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 21 2024, 4:48 PM

varun added a child revision: D12548: [web] fix uncaught exception bug.Jun 21 2024, 4:54 PM

Harbormaster completed remote builds in B29885: Diff 41629.Jun 21 2024, 5:07 PM

varun requested review of this revision.Jun 21 2024, 5:07 PM

Why did we introduce it initially? 🤨

This revision is now accepted and ready to land.Jun 21 2024, 10:54 PM

In D12547#355413, @bartek wrote:

Why did we introduce it initially? 🤨

i didn't think carefully enough about how reserved wallet addresses would be registered on identity

Closed by commit rCOMM54a1ca0f14e0: remove reserved wallet registration RPC (authored by varun). · Explain WhyJun 24 2024, 10:29 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM54a1ca0f14e0: remove reserved wallet registration RPC.

Revision Contents
Changeset List

Path

Size

lib/

types/

identity-service-types.js

8 lines

native/

cpp/

CommonCpp/

NativeModules/

CommRustModule.h

15 lines

CommRustModule.cpp

62 lines

_generated/

rustJSI-generated.cpp

rustJSI.h

identity-service/

identity-service-context-provider.react.js

42 lines

native_rust_library/

src/

identity.rs

9 lines

identity/

registration.rs

70 lines

lib.rs

18 lines

schema/

CommRustModuleSchema.js

15 lines

services/

identity/

src/

client_service.rs

83 lines

grpc_utils.rs

14 lines

shared/

protos/

identity_unauth.proto

26 lines

web/

protobufs/

identity-unauth-structs.cjs

identity-unauth-structs.cjs.flow

38 lines

identity-unauth.cjs

identity-unauth.cjs.flow

12 lines

Diff 41629

View Options

lib/types/identity-service-types.js

View Options

native/cpp/CommonCpp/NativeModules/CommRustModule.h

View Options

native/cpp/CommonCpp/NativeModules/CommRustModule.cpp

View Options

native/cpp/CommonCpp/_generated/rustJSI-generated.cpp

View Options

native/cpp/CommonCpp/_generated/rustJSI.h

View Options

native/identity-service/identity-service-context-provider.react.js

View Options

native/native_rust_library/src/identity.rs

View Options

native/native_rust_library/src/identity/registration.rs

View Options

native/native_rust_library/src/lib.rs

View Options

native/schema/CommRustModuleSchema.js

View Options

services/identity/src/client_service.rs

View Options

services/identity/src/grpc_utils.rs

View Options

shared/protos/identity_unauth.proto

View Options

web/protobufs/identity-unauth-structs.cjs

View Options

web/protobufs/identity-unauth-structs.cjs.flow

View Options

web/protobufs/identity-unauth.cjs

View Options

web/protobufs/identity-unauth.cjs.flow

remove reserved wallet registration RPCClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 41629

lib/types/identity-service-types.js

native/cpp/CommonCpp/NativeModules/CommRustModule.h

native/cpp/CommonCpp/NativeModules/CommRustModule.cpp

native/cpp/CommonCpp/_generated/rustJSI-generated.cpp

native/cpp/CommonCpp/_generated/rustJSI.h

native/identity-service/identity-service-context-provider.react.js

native/native_rust_library/src/identity.rs

native/native_rust_library/src/identity/registration.rs

native/native_rust_library/src/lib.rs

native/schema/CommRustModuleSchema.js

services/identity/src/client_service.rs

services/identity/src/grpc_utils.rs

shared/protos/identity_unauth.proto

web/protobufs/identity-unauth-structs.cjs

web/protobufs/identity-unauth-structs.cjs.flow

web/protobufs/identity-unauth.cjs

web/protobufs/identity-unauth.cjs.flow

remove reserved wallet registration RPC
ClosedPublic
Actions

Revision Contents
Changeset List