[lib] Change return type of `minimallyEncodeRawThreadInfo` to `RawThreadInfoWithMemberPermissions`
AbandonedPublic
Actions

Authored by atul on Jun 24 2024, 3:31 PM.

Details

Reviewers

ashoat
ginsu
tomek
varun

Summary

Introduce RawThreadInfoWithMemberPermissions which will be used for "legacy" migrations + on keyserver to handle old clients + old validator.

minimallyEncodeRawThreadInfo will encode permissions and return RawThreadInfoWithMemberPermissions. Will be used along with stripPermissionsFromMemberInfo on new clients + on keyserver to handle new clients.

NOTE: This diff "introduces flow issues to resolve a flow issue. Diffs after this in stack will be about resolving minimallyEncodeRawThreadInfo-related issues.

Depends on D12556

Test Plan

flow

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Jun 24 2024, 3:31 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 24 2024, 3:44 PM

Harbormaster failed remote builds in B29903: Diff 41662!

atul requested review of this revision.Jun 25 2024, 9:41 AM

atul added a child revision: D12573: [lib] Change `decodeMinimallyEncodedRawThreadInfo` argument type to `RawThreadInfoWithMemberPermissions`.Jun 25 2024, 9:54 AM

atul removed a parent revision: D12556: [lib] Remove `threadOrParentThreadHasAdminRole` and `memberHadAdminPowers`.Jun 26 2024, 1:48 PM

IMPORTANT: Even if there aren't any flow issues here, will need to be extra careful with changes to minimallyEncodeRawThreadInfo/minimallyDecodeRawThreadInfo to make sure things work correctly with previous persisted representation of data to avoid breaking things. That was the issue with the "dropping isDefault" migration.

IMPORTANT: We also may want to introduce a deprecated* variant of this function to ensure old migrations continue working even though we may not get flow issues.

Abandoning in favor of stack starting with D12594 because lots of things have changed and there's not really 1:1 correspondence with old stack and new stack so I don't think it makes sense to update in place, change a bunch of child/parent diff relationships, etc.

atul mentioned this in D12574: [native] Add `$FlowIgnore` annotation to migration 61.Jun 27 2024, 12:38 PM

atul mentioned this in D12594: [lib] Change type of `ThinRawThreadInfo.members` from `MemberInfoWithPermissions` to `MemberInfoSansPermissions`.