Page MenuHomePhabricator

[terraform] change cloudwatch subscription prefix from common to identity
ClosedPublic

Authored by will on Jun 24 2024, 9:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 24, 3:47 AM
Unknown Object (File)
Fri, Oct 18, 4:43 PM
Unknown Object (File)
Sep 25 2024, 9:48 PM
Unknown Object (File)
Sep 25 2024, 9:48 PM
Unknown Object (File)
Sep 25 2024, 9:48 PM
Unknown Object (File)
Sep 25 2024, 9:48 PM
Unknown Object (File)
Sep 20 2024, 1:06 AM
Unknown Object (File)
Sep 20 2024, 12:20 AM
Subscribers

Details

Summary

Typo. This should be prefixed by identity not common

Before landing, should use terraform state mv to ensure that we're not recreating the subscription

Test Plan

terraform apply

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will requested review of this revision.Jun 24 2024, 10:00 PM

Are you planning to use moved { } block? Or use terraform state mv to move it without recreating?

Are you planning to use moved { } block? Or use terraform state mv to move it without recreating?

This a really cool feature I didn't know existed. tbh, originally planned on just resubscribing but I'll use terraform state mv instead.

will edited the summary of this revision. (Show Details)
In D12563#355966, @will wrote:

Are you planning to use moved { } block? Or use terraform state mv to move it without recreating?

This a really cool feature I didn't know existed. tbh, originally planned on just resubscribing but I'll use terraform state mv instead.

Resubscribing is also okay (in this case) but you give terraform state mv a try 😉 In some cases it's important not to destroy your infra when just refactoring terraform.

This revision is now accepted and ready to land.Jun 26 2024, 2:24 AM