Page MenuHomePhabricator
Differential D12563

[terraform] change cloudwatch subscription prefix from common to identity
ClosedPublic
Actions

Authored by will on Jun 24 2024, 9:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 25, 9:48 PM
Unknown Object (File)
Wed, Sep 25, 9:48 PM
Unknown Object (File)
Wed, Sep 25, 9:48 PM
Unknown Object (File)
Wed, Sep 25, 9:48 PM
Unknown Object (File)
Fri, Sep 20, 1:06 AM
Unknown Object (File)
Fri, Sep 20, 12:20 AM
Unknown Object (File)
Sat, Aug 31, 8:06 PM
Unknown Object (File)
Sat, Aug 31, 3:11 AM
View All 34 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
Commits
rCOMM5c7fad19c1ab: [terraform] change cloudwatch subscription prefix from common to identity
Summary

Typo. This should be prefixed by identity not common

Before landing, should use terraform state mv to ensure that we're not recreating the subscription

Test Plan

terraform apply

Diff Detail

Repository
rCOMM Comm
Branch
cloudwatch_dns_alarm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will created this revision.Jun 24 2024, 9:43 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 24 2024, 9:43 PM
will added a child revision: D12564: [terraform] created combined error reports email.Jun 24 2024, 9:46 PM
Harbormaster completed remote builds in B29909: Diff 41669.Jun 24 2024, 10:00 PM
will requested review of this revision.Jun 24 2024, 10:00 PM
bartek added a comment.Jun 25 2024, 12:07 AM

Are you planning to use moved { } block? Or use terraform state mv to move it without recreating?

will added a comment.Jun 25 2024, 10:20 AM
In D12563#355851, @bartek wrote:

Are you planning to use moved { } block? Or use terraform state mv to move it without recreating?

This a really cool feature I didn't know existed. tbh, originally planned on just resubscribing but I'll use terraform state mv instead.

will edited the summary of this revision. (Show Details)Jun 25 2024, 10:20 AM
will edited the summary of this revision. (Show Details)
bartek accepted this revision.Jun 26 2024, 2:24 AM
In D12563#355966, @will wrote:
In D12563#355851, @bartek wrote:

Are you planning to use moved { } block? Or use terraform state mv to move it without recreating?

This a really cool feature I didn't know existed. tbh, originally planned on just resubscribing but I'll use terraform state mv instead.

Resubscribing is also okay (in this case) but you give terraform state mv a try 😉 In some cases it's important not to destroy your infra when just refactoring terraform.

This revision is now accepted and ready to land.Jun 26 2024, 2:24 AM
Closed by commit rCOMM5c7fad19c1ab: [terraform] change cloudwatch subscription prefix from common to identity (authored by will). · Explain WhyJun 26 2024, 3:05 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM5c7fad19c1ab: [terraform] change cloudwatch subscription prefix from common to identity.

Revision Contents
Changeset List

PathSize
services/
terraform/
remote/
2 lines

Diff 41669

View Options

services/terraform/remote/aws_cloudwatch_alarms.tf

Loading...