[web] intorduce loading logic to relationship prompt button
Needs ReviewPublic
Actions

Authored by ginsu on Thu, Jun 27, 12:50 PM.

Details

Reviewers

ashoat
inka

Summary

This diff updates the relationship prompt button in web to consume the loading logic from useRelationshipPrompt

Depends on D12593

Test Plan

Confirmed that the loading logic works as expected in the relationship prompt button for both the relationship prompt and user profiles

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

ginsu added inline comments.

web/chat/relationship-prompt/relationship-prompt-button.js
16	Made `isLoading` required so we can be more proactive in the future about always including loading state in our action buttons
web/chat/relationship-prompt/relationship-prompt.js
51	Having every word be capitalized is a bit of an anti-pattern, went ahead and updated the copy to follow the convention of only the first word being capitalized but happy to revert this if this is unwanted cc @ashoat
web/modals/user-profile/user-profile-action-buttons.react.js
49	Can't really remember why we initially dropped the "friend request" in the copy but added it back to be consistent with what is found in `RelationshipPrompt` component. If this change is okay, will update this diff to dedup the copy-pasted strings before landing cc @ashoat