This diff updates the relationship prompt button in web to consume the loading logic from useRelationshipPrompt
Depends on D12593
Details
Details
Confirmed that the loading logic works as expected in the relationship prompt button for both the relationship prompt and user profiles
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| web/chat/relationship-prompt/relationship-prompt-button.js | ||
|---|---|---|
| 16 ↗ | (On Diff #41767) | Made isLoading required so we can be more proactive in the future about always including loading state in our action buttons |
| web/chat/relationship-prompt/relationship-prompt.js | ||
| 51 ↗ | (On Diff #41767) | Having every word be capitalized is a bit of an anti-pattern, went ahead and updated the copy to follow the convention of only the first word being capitalized but happy to revert this if this is unwanted cc @ashoat |
| web/modals/user-profile/user-profile-action-buttons.react.js | ||
| 49 ↗ | (On Diff #41767) | Can't really remember why we initially dropped the "friend request" in the copy but added it back to be consistent with what is found in RelationshipPrompt component. If this change is okay, will update this diff to dedup the copy-pasted strings before landing cc @ashoat |
| web/chat/relationship-prompt/relationship-prompt.js | ||
|---|---|---|
| 51 ↗ | (On Diff #41767) | Thank you for catching this!! |
| web/modals/user-profile/user-profile-action-buttons.react.js | ||
| 49 ↗ | (On Diff #41767) | Thanks for making this change for consistency, and yes would be great to dedup! Can you share a screenshot so we can make sure that the increased text doesn't overflow its bounds? |
| web/modals/user-profile/user-profile-action-buttons.react.js | ||
|---|---|---|
| 49 ↗ | (On Diff #41767) |  The text isn't overflowing it's bounds and I feel like it isn't too scrunched up; however, based on feedback in D12596, I think we should drop the "friend request" so that the copy in the user profiles will be consistent between web and native |
| web/modals/user-profile/user-profile-action-buttons.react.js | ||
|---|---|---|
| 49 ↗ | (On Diff #41767) | Yeah, good call on consistency – let's do it |