Page MenuHomePhabricator
Differential D12600

[native] use RelationshipButton in RelationshipPrompt
Needs ReviewPublic
Actions

Authored by ginsu on Thu, Jun 27, 2:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 29, 1:48 AM
Unknown Object (File)
Sat, Jun 29, 1:48 AM
Unknown Object (File)
Sat, Jun 29, 1:48 AM
Unknown Object (File)
Sat, Jun 29, 1:48 AM
Unknown Object (File)
Sat, Jun 29, 1:48 AM
Unknown Object (File)
Sat, Jun 29, 1:45 AM
Unknown Object (File)
Thu, Jun 27, 7:37 PM
Subscribers
ashoat
tomek

Details

Reviewers
inka
ashoat
Summary

This diff updates RelationshipPrompt to use the RelationshipButton component rather than the current inline buttons

Depends on D12596

Test Plan

Confirmed that the relationship prompt buttons in the relationship prompt show a loading spinner when the action is in progress

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Thu, Jun 27, 2:08 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Jun 27, 2:08 PM
ginsu updated this revision to Diff 41774.Thu, Jun 27, 2:11 PM

update

ginsu edited the summary of this revision. (Show Details)Thu, Jun 27, 2:12 PM
ginsu added reviewers: inka, ashoat.
ginsu added a parent revision: D12596: [native] introduce loading logic to relationship prompt button.
ginsu updated this revision to Diff 41776.Thu, Jun 27, 2:16 PM

update

native/chat/relationship-prompt.react.js
169 ↗(On Diff #41776)

Hardcoded the height here so that we guarantee that when the button state goes to loading then the height of the button never changes; however, recently got some feedback about hardcoding the height in CSS being a no-no. Looks like visibility: hidden is not supported in react native, but if we still don't want this, I can explore other ways of doing this

This height was determined by using the element inspector in my simulator

ginsu updated this revision to Diff 41777.Thu, Jun 27, 2:18 PM

forgot to hit save

native/chat/relationship-prompt.react.js
169

Hardcoded the height here so that we guarantee that when the button state goes to loading then the height of the button never changes; however, recently got some feedback about hardcoding the height in CSS being a no-no. Looks like visibility: hidden is not supported in react native, but if we still don't want this, I can explore other ways of doing this

This height was determined by using the element inspector in my simulator

Harbormaster completed remote builds in B29975: Diff 41774.Thu, Jun 27, 2:26 PM
Harbormaster completed remote builds in B29974: Diff 41773.Thu, Jun 27, 2:29 PM
Harbormaster completed remote builds in B29977: Diff 41776.Thu, Jun 27, 2:34 PM
Harbormaster completed remote builds in B29978: Diff 41777.Thu, Jun 27, 2:38 PM
ginsu requested review of this revision.Thu, Jun 27, 2:38 PM

Revision Contents
Changeset List

PathSize
native/
chat/
130 lines

Diff 41777

View Options

native/chat/relationship-prompt.react.js

Loading...