[native] introduce LoadableButton
ClosedPublic
Actions

Authored by ginsu on Wed, Jul 3, 10:14 AM.

Details

Reviewers

ashoat
inka

Commits

rCOMM4577aa80a243: [native] introduce LoadableButton

Summary

Got some feedback in D12600 to factor out some logic into it's own component. This diff addresses that feedback

Test Plan

Confirmed that the loading spinners in the relationship buttons still work as expected

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Wed, Jul 3, 10:14 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptWed, Jul 3, 10:14 AM

ginsu added a child revision: D12593: [lib] introduce loading logic to useRelationshipPrompt.Wed, Jul 3, 10:15 AM

ginsu mentioned this in D12600: [native] introduce loading logic to RelationshipPrompt.

ginsu added reviewers: ashoat, inka.

ginsu edited the summary of this revision. (Show Details)Wed, Jul 3, 10:28 AM

Harbormaster completed remote builds in B30087: Diff 41951.Wed, Jul 3, 10:31 AM

ginsu requested review of this revision.Wed, Jul 3, 10:31 AM

ashoat accepted this revision.Wed, Jul 3, 10:46 AM

This revision is now accepted and ready to land.Wed, Jul 3, 10:46 AM

rebase before landing

This revision was landed with ongoing or failed builds.Wed, Jul 3, 3:13 PM

Closed by commit rCOMM4577aa80a243: [native] introduce LoadableButton (authored by ginsu). · Explain Why

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM4577aa80a243: [native] introduce LoadableButton.

Harbormaster completed remote builds in B30094: Diff 41958.Wed, Jul 3, 3:25 PM

Revision Contents
Changeset List

Path

Size

native/

components/

loadable-button.react.js

80 lines

Diff 41965

View Options

native/components/loadable-button.react.js

[native] introduce LoadableButtonClosedPublicActions