[identity] downgrade no auth message error to warning
ClosedPublic
Actions

Authored by will on Jun 28 2024, 4:25 PM.

Details

Reviewers

bartek
varun

Commits

rCOMM200062e6eea2: [identity] downgrade no auth message error to warning

Summary

I don't think this needs to be an error. This was triggered recently and might've been a websocket health check or something related.

Test Plan

cargo build

Diff Detail

Repository

rCOMM Comm

Branch

cloudwatch/identity

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

will created this revision.Jun 28 2024, 4:25 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 28 2024, 4:25 PM

Harbormaster completed remote builds in B30014: Diff 41830.Jun 28 2024, 4:41 PM

will requested review of this revision.Jun 28 2024, 4:41 PM

bartek accepted this revision.Jul 1 2024, 2:36 AM

This revision is now accepted and ready to land.Jul 1 2024, 2:36 AM

This was triggered recently and might've been a websocket health check or something related.

It's worth checking if clients aren't broken and they do send the message

In D12623#357165, @bartek wrote:

This was triggered recently and might've been a websocket health check or something related.

It's worth checking if clients aren't broken and they do send the message

Was able to test this before when running identity search on a debug iOS client. Don't believe clients are broken.

rebase

Harbormaster completed remote builds in B30679: Diff 42785.Jul 25 2024, 2:36 PM

Closed by commit rCOMM200062e6eea2: [identity] downgrade no auth message error to warning (authored by will). · Explain WhyJul 25 2024, 2:38 PM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMM200062e6eea2: [identity] downgrade no auth message error to warning.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

websockets/

mod.rs

5 lines

Diff 42785

View Options

services/identity/src/websockets/mod.rs

This file was added.

				// @flow

				import type {
				StackNavigationEventMap,
				StackNavigationState,
				StackOptions,
				} from '@react-navigation/core';
				import * as React from 'react';
				import { Text } from 'react-native';

				import { type QRAuthNavigationProp } from './qr-auth-navigator.react.js';
				import RegistrationButtonContainer from '../../account/registration/registration-button-container.react.js';
				import RegistrationContainer from '../../account/registration/registration-container.react.js';
				import RegistrationContentContainer from '../../account/registration/registration-content-container.react.js';
				import PrimaryButton from '../../components/primary-button.react.js';
				import type { RootNavigationProp } from '../../navigation/root-navigator.react.js';
				import {
				type NavigationRoute,
				type ScreenParamList,
				} from '../../navigation/route-names.js';
				import { useStyles } from '../../themes/colors.js';

				type Props = {
				+navigation: QRAuthNavigationProp<'QRAuthNotPrimaryDevice'>,
				+route: NavigationRoute<'QRAuthNotPrimaryDevice'>,
				};

				function QRAuthNotPrimaryDevice(prop: Props): React.Node {
				const { navigation } = prop;
				const styles = useStyles(unboundStyles);

				const onPressGoBack = React.useCallback(() => {
				navigation
				.getParent<
				ScreenParamList,
				'LinkedDevicesBottomSheet',
				StackNavigationState,
				StackOptions,
				StackNavigationEventMap,
				RootNavigationProp<'LinkedDevicesBottomSheet'>,
				>()
				?.goBack();
				}, [navigation]);

				return (
				<RegistrationContainer>
				<RegistrationContentContainer>
				<Text style={styles.header}>Device not primary</Text>
				<Text style={styles.body}>
				This mobile device is not your primary device, and cannot be used to
				authorize new devices. Please try your other mobile device(s).
				</Text>
				</RegistrationContentContainer>
				<RegistrationButtonContainer>
				<PrimaryButton
				onPress={onPressGoBack}
				label="Go back"
				variant="enabled"
				/>
				</RegistrationButtonContainer>
				</RegistrationContainer>
				);
				}

				const unboundStyles = {
				header: {
				fontSize: 24,
				color: 'panelForegroundLabel',
				paddingBottom: 16,
				},
				body: {
				fontFamily: 'Arial',
				fontSize: 15,
				lineHeight: 20,
				color: 'panelForegroundSecondaryLabel',
				paddingBottom: 16,
				},
				};

				export default QRAuthNotPrimaryDevice;

[identity] downgrade no auth message error to warningClosedPublicActions