[landing] extend exiting competitor comparison code to handle new differentiation section
ClosedPublic
Actions

Authored by ginsu on Jul 1 2024, 7:16 AM.

Details

Reviewers

inka
ashoat

Commits

rCOMMf5f890054d4f: [landing] extend exiting competitor comparison code to handle new…

Summary

This diff extends our preexiting logic for the competitor comparison to better handle a new section explaining how Comm is differentiated. At the moment, the copy is not ready and given that I will be leaving in a few days, I made the copy for this new section just be lorum ipsum dummy text that should be easy to update and replace.

Test Plan

flow + confirmed later on in the stack that the new section was properly introduced

Screenshot 2024-07-01 at 10.18.36 AM.png (2×3 px, 904 KB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Jul 1 2024, 7:16 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 1 2024, 7:16 AM

ginsu edited the summary of this revision. (Show Details)Jul 1 2024, 7:19 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: inka, ashoat.

ginsu attached a referenced file: F2159541: Screenshot 2024-07-01 at 10.18.36 AM.png. (Show Details)

ginsu added inline comments.Jul 1 2024, 7:21 AM

landing/competitor-logo.react.js
21 ↗	(On Diff #41851)	In this new section we are not directly comparing with a specific competitor so I felt that it made most sense that for this new "general" differentiation section had no logo/icon