Page MenuHomePhabricator
Differential D12629

[landing] extend exiting competitor comparison code to handle new differentiation section
ClosedPublic
Actions

Authored by ginsu on Mon, Jul 1, 7:16 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jul 5, 4:43 AM
Unknown Object (File)
Tue, Jul 2, 6:02 PM
Unknown Object (File)
Tue, Jul 2, 6:02 PM
Unknown Object (File)
Tue, Jul 2, 6:01 PM
Unknown Object (File)
Tue, Jul 2, 6:00 PM
F2159541: Screenshot 2024-07-01 at 10.18.36 AM.png
Mon, Jul 1, 7:19 AM
Subscribers
ashoat
tomek

Details

Reviewers
inka
ashoat
Commits
rCOMMf5f890054d4f: [landing] extend exiting competitor comparison code to handle new…
Summary

This diff extends our preexiting logic for the competitor comparison to better handle a new section explaining how Comm is differentiated. At the moment, the copy is not ready and given that I will be leaving in a few days, I made the copy for this new section just be lorum ipsum dummy text that should be easy to update and replace.

Test Plan

flow + confirmed later on in the stack that the new section was properly introduced

Screenshot 2024-07-01 at 10.18.36 AM.png (2×3 px, 904 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Mon, Jul 1, 7:16 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMon, Jul 1, 7:16 AM
ginsu edited the summary of this revision. (Show Details)Mon, Jul 1, 7:19 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: inka, ashoat.
ginsu attached a referenced file: F2159541: Screenshot 2024-07-01 at 10.18.36 AM.png. (Show Details)
ginsu added inline comments.Mon, Jul 1, 7:21 AM
landing/competitor-logo.react.js
21 ↗(On Diff #41851)

In this new section we are not directly comparing with a specific competitor so I felt that it made most sense that for this new "general" differentiation section had no logo/icon

Harbormaster completed remote builds in B30027: Diff 41851.Mon, Jul 1, 7:33 AM
ginsu requested review of this revision.Mon, Jul 1, 7:33 AM
ginsu added a child revision: D12630: [landing] switch comparison order in CompetitorFeature.Mon, Jul 1, 7:43 AM
ashoat accepted this revision.Mon, Jul 1, 5:45 PM
This revision is now accepted and ready to land.Mon, Jul 1, 5:45 PM
Closed by commit rCOMMf5f890054d4f: [landing] extend exiting competitor comparison code to handle new… (authored by ginsu). · Explain WhyMon, Jul 1, 7:28 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMf5f890054d4f: [landing] extend exiting competitor comparison code to handle new….

Revision Contents
Changeset List

PathSize
landing/
93 lines
16 lines

Diff 41863

View Options

landing/competitor-data.js

Loading...
View Options

landing/competitor-logo.react.js

Loading...