This diff introduces the new differentiation section on the landing page. Since the copy for this section is not ready atm, I gated this section behind a flag that can easily be enabled/disabled when ready
Depends on D12630
Differential D12631
[landing] introduce differenation section ginsu on Jul 1 2024, 7:27 AM. Authored by Tags None Referenced Files
Details
This diff introduces the new differentiation section on the landing page. Since the copy for this section is not ready atm, I gated this section behind a flag that can easily be enabled/disabled when ready Depends on D12630 Please see the demo video below
Diff Detail
Event TimelineComment Actions Wondering, if we wanted to include a graphic how would we do it here? Maybe on the pop-up cards? Is there a way to do that in competitorData currently?
Comment Actions fix feature flag
Comment Actions
The best way to go about this would be to add a new general case in competitor-logo.react.js. I initially tried to find a good graphic/icon for this, but wasn't able to find anything really good so I thought it would be better to just not include a graphic. https://github.com/CommE2E/comm/blob/master/landing/competitor-logo.react.js
The CompetitorFeature component is shared between the normal cards and the pop up cards, so if we only want to show a graphic/icon on the pop-up cards we would need to introduce additional logic to make this happen, but it shouldn't be anything too crazy Let me know if you would like to see me do any of this as a quick follow up Comment Actions I mean less like an icon, and more like a graphic of the functionality. Eg. for the tree structure piece we could include a screenshot of the navigation side drawer Comment Actions
Oh gotcha. Yea the best way to go about this would be to conditionally render the graphic in competitor-feature.react.js (in between the div with the .headingContainer class name and the CommLogo component). return ( <div className={css.container}> <div className={css.headingContainer}> <p className={headingClassName}>{title}</p> {comingSoonBadge} </div> {/* Introduce conditional graphic here */} <CommLogo size={30} /> {commInfo} <hr /> <CompetitorLogo name={competitorID} size={30} /> {competitorInfo} </div> ); We should conditionally render this graphic based on some newly introduced props since we probably only want to show the graphic on the larger pop-up cards, and the graphic should use the competitorID prop to determine which graphic should be shown |