Page MenuHomePhabricator
Differential D12630

[landing] switch comparison order in CompetitorFeature
ClosedPublic
Actions

Authored by ginsu on Mon, Jul 1, 7:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jul 2, 6:02 PM
Unknown Object (File)
Tue, Jul 2, 6:02 PM
Unknown Object (File)
Tue, Jul 2, 6:01 PM
Unknown Object (File)
Tue, Jul 2, 6:01 PM
Unknown Object (File)
Tue, Jul 2, 2:02 AM
F2163178: Screenshot 2024-07-01 at 10.26.00 PM.png
Mon, Jul 1, 7:26 PM
F2159615: Screenshot 2024-07-01 at 10.18.36 AM.png
Mon, Jul 1, 7:25 AM
F2159613: Screenshot 2024-07-01 at 10.24.34 AM.png
Mon, Jul 1, 7:25 AM
Subscribers
ashoat
tomek

Details

Reviewers
ashoat
inka
Commits
rCOMM2b33c26be1c2: [landing] switch comparison order in CompetitorFeature
Summary

Currently our comparison cards has an order where our competitor description is first then the Comm description comes afterwards. I felt that with this new differentiation section, and more generally too that it would make more sense to switch the comparison order to have the comm description go first then the competitor

Depends on D12629

Test Plan

Confirmed that there were no regressions + please see the screenshots below

Screenshot 2024-07-01 at 10.24.34 AM.png (1×3 px, 660 KB)

Screenshot 2024-07-01 at 10.18.36 AM.png (2×3 px, 904 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Mon, Jul 1, 7:24 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMon, Jul 1, 7:24 AM
ginsu edited the summary of this revision. (Show Details)Mon, Jul 1, 7:25 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: ashoat, inka.
ginsu edited the test plan for this revision. (Show Details)
ginsu attached a referenced file: F2159615: Screenshot 2024-07-01 at 10.18.36 AM.png. (Show Details)
ginsu attached a referenced file: F2159613: Screenshot 2024-07-01 at 10.24.34 AM.png. (Show Details)
Harbormaster completed remote builds in B30028: Diff 41852.Mon, Jul 1, 7:41 AM
ginsu requested review of this revision.Mon, Jul 1, 7:41 AM
ginsu edited the summary of this revision. (Show Details)Mon, Jul 1, 7:43 AM
ginsu added a parent revision: D12629: [landing] extend exiting competitor comparison code to handle new differentiation section.
ginsu added a child revision: D12631: [landing] introduce differenation section.Mon, Jul 1, 8:00 AM
ashoat accepted this revision.Mon, Jul 1, 5:46 PM

I think it's a good call. Does this also change the order in the pop-up cards with the long descriptions? If not, can you flip the order there too?

This revision is now accepted and ready to land.Mon, Jul 1, 5:46 PM
ginsu added a comment.Mon, Jul 1, 7:26 PM

Does this also change the order in the pop-up cards with the long descriptions? If not, can you flip the order there too?

Yes the CompetitorFeature component is shared between the normal cards and the pop up cards

Screenshot 2024-07-01 at 10.26.00 PM.png (2×3 px, 868 KB)

Closed by commit rCOMM2b33c26be1c2: [landing] switch comparison order in CompetitorFeature (authored by ginsu). · Explain WhyMon, Jul 1, 7:28 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM2b33c26be1c2: [landing] switch comparison order in CompetitorFeature.

Revision Contents
Changeset List

PathSize
landing/
6 lines

Diff 41864

View Options

landing/competitor-feature.react.js

Loading...