Page MenuHomePhabricator

[lib] remove integrity store assertion and use sqlite
ClosedPublic

Authored by will on Jul 8 2024, 5:14 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 2:40 PM
Unknown Object (File)
Wed, Nov 20, 2:25 PM
Unknown Object (File)
Wed, Nov 20, 2:25 PM
Unknown Object (File)
Fri, Nov 8, 8:57 AM
Unknown Object (File)
Mon, Nov 4, 2:10 PM
Unknown Object (File)
Sun, Nov 3, 5:30 AM
Unknown Object (File)
Oct 22 2024, 1:16 PM
Unknown Object (File)
Oct 22 2024, 9:08 AM
Subscribers

Details

Summary

This removes integrity store from redux persist and instead utilizes sqlite to populate redux state

Test Plan

Tested on debug native and web

Web redux tools correctly shows populated redux state with thread hashes

Native iOS simulator does not result in any errors

Diff Detail

Repository
rCOMM Comm
Branch
sqlite/integrity_store
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

@kamil does anything need to be done to remove redux persist integrityStore data besides adding to the persistBlacklist? On initial startup, I get a hydrated keys not expected integrityStore which doesn't appear on subsequent app opens in debug iOS Simulator

will requested review of this revision.Jul 8 2024, 5:30 AM
In D12686#359268, @will wrote:

@kamil does anything need to be done to remove redux persist integrityStore data besides adding to the persistBlacklist? On initial startup, I get a hydrated keys not expected integrityStore which doesn't appear on subsequent app opens in debug iOS Simulator

I think this is fine, this is just a log and each one should see it only once - Alternatively, we can add a migration to explicitly remove integrityStore but I don't think it is worth it.

lib/reducers/integrity-reducer.js
32

this can be removed now

This revision is now accepted and ready to land.Jul 12 2024, 2:17 AM

review feedback and rebase