[lib] remove integrity store assertion and use sqlite
ClosedPublic
Actions

Authored by will on Jul 8 2024, 5:14 AM.

Details

Reviewers

kamil
tomek

Commits

rCOMM3a325b4a239f: [lib] remove integrity store assertion and use sqlite

Summary

This removes integrity store from redux persist and instead utilizes sqlite to populate redux state

Test Plan

Tested on debug native and web

Web redux tools correctly shows populated redux state with thread hashes

Native iOS simulator does not result in any errors

Diff Detail

Repository

rCOMM Comm

Branch

sqlite/integrity_store

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

will created this revision.Jul 8 2024, 5:14 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJul 8 2024, 5:14 AM

@kamil does anything need to be done to remove redux persist integrityStore data besides adding to the persistBlacklist? On initial startup, I get a hydrated keys not expected integrityStore which doesn't appear on subsequent app opens in debug iOS Simulator

Harbormaster completed remote builds in B30190: Diff 42102.Jul 8 2024, 5:30 AM

will requested review of this revision.Jul 8 2024, 5:30 AM

In D12686#359268, @will wrote:

@kamil does anything need to be done to remove redux persist integrityStore data besides adding to the persistBlacklist? On initial startup, I get a hydrated keys not expected integrityStore which doesn't appear on subsequent app opens in debug iOS Simulator

I think this is fine, this is just a log and each one should see it only once - Alternatively, we can add a migration to explicitly remove integrityStore but I don't think it is worth it.