Page MenuHomePhabricator

[native][web] Add a method fetching messages by ID
ClosedPublic

Authored by tomek on Jul 15 2024, 4:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 18, 10:24 PM
Unknown Object (File)
Fri, Oct 18, 1:58 PM
Unknown Object (File)
Fri, Oct 18, 10:25 AM
Unknown Object (File)
Mon, Oct 14, 7:00 AM
Unknown Object (File)
Thu, Oct 10, 5:26 AM
Unknown Object (File)
Oct 4 2024, 3:29 AM
Unknown Object (File)
Sep 26 2024, 10:09 AM
Unknown Object (File)
Sep 25 2024, 7:05 PM
Subscribers

Details

Summary

This allows retrying messages generated by a single action.

https://linear.app/comm/issue/ENG-8675/add-option-to-manually-retry-a-message

Depends on D12743

Test Plan

Tested in combination with the rest of the stack. Sending messages requires calling this API so checking if messages are sent tests it.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 15 2024, 4:25 AM
Harbormaster failed remote builds in B30321: Diff 42282!

Rename, fix compilation issue

tomek requested review of this revision.Jul 16 2024, 5:06 AM
kamil added inline comments.
native/cpp/CommonCpp/DatabaseManagers/entities/EntityQueryHelpers.h
79 ↗(On Diff #42388)

shouldn't this be getAllEntitiesByPrimaryKeys?

This revision is now accepted and ready to land.Jul 18 2024, 6:04 AM

Rename

native/cpp/CommonCpp/DatabaseManagers/entities/EntityQueryHelpers.h
79 ↗(On Diff #42388)

Yes, it should