Some boilerplate for writing and reading the field from D12742.
https://linear.app/comm/issue/ENG-8729/automatic-retries-for-non-composable-dms
Depends on D12742
Paths
| Differential D12743 Authored by tomek on Jul 15 2024, 3:49 AM.
Details
Summary Some boilerplate for writing and reading the field from D12742. https://linear.app/comm/issue/ENG-8729/automatic-retries-for-non-composable-dms Depends on D12742 Test Plan Tested later in the stack by checking if the message with this field can be saved and read.
Diff Detail
Event TimelineHerald added a subscriber: ashoat. · View Herald TranscriptJul 15 2024, 3:49 AM2024-07-15 03:49:56 (UTC-7) tomek edited the summary of this revision. (Show Details)Jul 15 2024, 3:50 AM2024-07-15 03:50:26 (UTC-7) Harbormaster returned this revision to the author for changes because remote builds failed.Jul 15 2024, 4:26 AM2024-07-15 04:26:09 (UTC-7) Harbormaster completed remote builds in B30320: Diff 42281.Jul 16 2024, 3:34 AM2024-07-16 03:34:27 (UTC-7) This revision is now accepted and ready to land.Jul 16 2024, 3:40 AM2024-07-16 03:40:19 (UTC-7) Harbormaster completed remote builds in B30377: Diff 42340.Jul 16 2024, 5:01 AM2024-07-16 05:01:12 (UTC-7) Harbormaster completed remote builds in B30408: Diff 42379.Jul 17 2024, 5:44 AM2024-07-17 05:44:07 (UTC-7) Harbormaster completed remote builds in B30415: Diff 42387.Jul 17 2024, 9:34 AM2024-07-17 09:34:26 (UTC-7) Closed by commit rCOMM51d27bec0c9b: Add a new field to OutboundP2PMessage (authored by tomek). · Explain WhyJul 19 2024, 7:47 AM2024-07-19 07:47:31 (UTC-7) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 42539 lib/types/sqlite-types.js
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
native/cpp/CommonCpp/DatabaseManagers/entities/OutboundP2PMessage.h
native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
web/cpp/SQLiteQueryExecutorBindings.cpp
web/shared-worker/_generated/comm-query-executor.js
web/shared-worker/_generated/comm_query_executor.wasm
|