Page MenuHomePhabricator
Differential D12775

[lib] Fix an invalid condition
ClosedPublic
Actions

Authored by tomek on Jul 16 2024, 6:14 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 5, 7:39 AM
Unknown Object (File)
Thu, Feb 27, 6:00 AM
Unknown Object (File)
Fri, Feb 21, 6:44 AM
Unknown Object (File)
Fri, Feb 21, 6:44 AM
Unknown Object (File)
Thu, Feb 20, 7:29 PM
Unknown Object (File)
Jan 30 2025, 3:19 AM
Unknown Object (File)
Jan 24 2025, 6:38 AM
Unknown Object (File)
Jan 24 2025, 6:38 AM
View All 68 Files
Subscribers
ashoat

Details

Reviewers
kamil
marcin
Commits
rCOMM5eba6c1c763d: [lib] Fix an invalid condition
Summary

We should check the accessToken instead of checking userID twice.

Depends on D12749

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
tunnelbroker/
6 lines

Diff 42544

View Options

lib/tunnelbroker/peer-to-peer-context.js

Show First 20 Lines • Show All 122 Lines • ▼ Show 20 Lines const mediaID =
request.type === 'image' || request.type === 'encrypted_image' request.type === 'image' || request.type === 'encrypted_image'
? request.uploadID ? request.uploadID
: null; : null;
const query = SQL` const query = SQL`
START TRANSACTION; START TRANSACTION;
UPDATE uploads UPDATE uploads
SET container = NULL SET user_container = NULL
WHERE uploader = ${viewer.userID} WHERE uploader = ${viewer.userID}
AND container = ${viewer.userID} AND user_container = ${viewer.userID}
AND ( AND (
${mediaID} IS NULL ${mediaID} IS NULL
OR EXISTS ( OR EXISTS (
SELECT 1 SELECT 1
FROM uploads FROM uploads
WHERE id = ${mediaID} WHERE id = ${mediaID}
AND uploader = ${viewer.userID} AND uploader = ${viewer.userID}
AND container IS NULL AND container IS NULL
AND user_container IS NULL
AND thread IS NULL AND thread IS NULL
) )
); );
UPDATE uploads UPDATE uploads
SET container = ${viewer.userID} SET user_container = ${viewer.userID}
WHERE id = ${mediaID} WHERE id = ${mediaID}
AND uploader = ${viewer.userID} AND uploader = ${viewer.userID}
AND container IS NULL AND container IS NULL
AND user_container IS NULL
AND thread IS NULL; AND thread IS NULL;
UPDATE users UPDATE users
SET avatar = ${newAvatarValue} SET avatar = ${newAvatarValue}
WHERE id = ${viewer.userID} WHERE id = ${viewer.userID}
AND ( AND (
${mediaID} IS NULL ${mediaID} IS NULL
OR EXISTS ( OR EXISTS (
SELECT 1 SELECT 1
FROM uploads FROM uploads
WHERE id = ${mediaID} WHERE id = ${mediaID}
AND uploader = ${viewer.userID} AND uploader = ${viewer.userID}
AND container = ${viewer.userID} AND user_container = ${viewer.userID}
AND thread IS NULL AND thread IS NULL
) )
); );
COMMIT; COMMIT;
SELECT id AS upload_id, secret AS upload_secret, extra AS upload_extra SELECT id AS upload_id, secret AS upload_secret, extra AS upload_extra
FROM uploads FROM uploads
WHERE id = ${mediaID} WHERE id = ${mediaID}
AND uploader = ${viewer.userID} AND uploader = ${viewer.userID}
AND container = ${viewer.userID}; AND user_container = ${viewer.userID};
`; `;
const [resultSet] = await dbQuery(query, { multipleStatements: true }); const [resultSet] = await dbQuery(query, { multipleStatements: true });
const selectResult = resultSet.pop(); const selectResult = resultSet.pop();
const knownUserInfos: UserInfos = await fetchKnownUserInfos(viewer); const knownUserInfos: UserInfos = await fetchKnownUserInfos(viewer);
const updates: CreateUpdatesResult = await createUserAvatarUpdates( const updates: CreateUpdatesResult = await createUserAvatarUpdates(
viewer, viewer,
▲ Show 20 Lines • Show All 71 Lines • Show Last 20 Lines