Some boilerplate for writing and reading the field from D12742.
https://linear.app/comm/issue/ENG-8729/automatic-retries-for-non-composable-dms
Depends on D12742
Differential D12743 Authored by tomek on Jul 15 2024, 10:49 AM.
Details
Summary Some boilerplate for writing and reading the field from D12742. https://linear.app/comm/issue/ENG-8729/automatic-retries-for-non-composable-dms Depends on D12742 Test Plan Tested later in the stack by checking if the message with this field can be saved and read.
Diff Detail
Event TimelineHerald added a subscriber: ashoat. · View Herald TranscriptJul 15 2024, 10:49 AM2024-07-15 10:49:56 (UTC+0) tomek edited the summary of this revision. (Show Details)Jul 15 2024, 10:50 AM2024-07-15 10:50:26 (UTC+0) Harbormaster returned this revision to the author for changes because remote builds failed.Jul 15 2024, 11:26 AM2024-07-15 11:26:09 (UTC+0) Harbormaster completed remote builds in B30320: Diff 42281.Jul 16 2024, 10:34 AM2024-07-16 10:34:27 (UTC+0) This revision is now accepted and ready to land.Jul 16 2024, 10:40 AM2024-07-16 10:40:19 (UTC+0) Harbormaster completed remote builds in B30377: Diff 42340.Jul 16 2024, 12:01 PM2024-07-16 12:01:12 (UTC+0) Harbormaster completed remote builds in B30408: Diff 42379.Jul 17 2024, 12:44 PM2024-07-17 12:44:07 (UTC+0) Harbormaster completed remote builds in B30415: Diff 42387.Jul 17 2024, 4:34 PM2024-07-17 16:34:26 (UTC+0) Closed by commit rCOMM51d27bec0c9b: Add a new field to OutboundP2PMessage. · Explain WhyJul 19 2024, 2:47 PM2024-07-19 14:47:31 (UTC+0) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 42387 |