Page MenuHomePhabricator
Differential D12765

[Tunnelbroker] implement requesting FCM access token using OAuth 2.0
ClosedPublic
Actions

Authored by kamil on Jul 16 2024, 1:21 AM.
Tags
None
Referenced Files
F3139028: D12765.diff
Sun, Nov 3, 1:44 AM
Unknown Object (File)
Sat, Nov 2, 2:23 AM
Unknown Object (File)
Sat, Nov 2, 2:23 AM
Unknown Object (File)
Sat, Nov 2, 2:23 AM
Unknown Object (File)
Sat, Nov 2, 2:11 AM
Unknown Object (File)
Fri, Nov 1, 10:18 AM
Unknown Object (File)
Fri, Nov 1, 10:18 AM
Unknown Object (File)
Fri, Nov 1, 10:18 AM
View All 42 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
marcin
Commits
rCOMM61a0eb1ab64f: [Tunnelbroker] implement requesting FCM access token using OAuth 2.0
Summary

Implementing what is described in Google's OAuth 2.0 for Server to Server Applications, Making the access token request.

Token lifetime implemented in next diff.

Depends on D12754

Test Plan

Call get_fcm_access_token with get_jwt_token result and print responses.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Jul 16 2024, 1:21 AM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 16 2024, 1:21 AM
kamil added a child revision: D12766: [Tunnelbroker] implement FCM Access Token lifetime.Jul 16 2024, 1:21 AM
Harbormaster completed remote builds in B30360: Diff 42322.Jul 16 2024, 1:37 AM
kamil published this revision for review.Jul 16 2024, 2:38 AM
kamil added inline comments.
services/tunnelbroker/src/notifs/fcm/token.rs
13–17 ↗(On Diff #42322)

according to docs, here should be also scope, but for some reason there is no scope field in response

bartek accepted this revision.Jul 18 2024, 7:15 AM
bartek mentioned this in D12754: [Tunnelbroker] implement OAuth 2.0 JWT token encoding.
This revision is now accepted and ready to land.Jul 18 2024, 7:15 AM
Closed by commit rCOMM61a0eb1ab64f: [Tunnelbroker] implement requesting FCM access token using OAuth 2.0 (authored by kamil). · Explain WhyJul 19 2024, 5:05 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM61a0eb1ab64f: [Tunnelbroker] implement requesting FCM access token using OAuth 2.0.

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
src/
notifs/
fcm/
24 lines

Diff 42525

View Options

services/tunnelbroker/src/notifs/fcm/token.rs

Loading...