[Tunnelbroker] implement FCM Access Token lifetime
ClosedPublic
Actions

Authored by kamil on Jul 16 2024, 1:21 AM.

Details

Reviewers

bartek
marcin

Commits

rCOMMcb4ca298599a: [Tunnelbroker] implement FCM Access Token lifetime

Summary

Implementing what is described in Google's OAuth 2.0 for Server to Server Applications.

Depends on D12765

Test Plan

Call get_auth_bearer and make sure it's regenerated when needed. Later in the stack I tested both sending notif with correct and incorrect access token

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jul 16 2024, 1:21 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 16 2024, 1:21 AM

kamil added a child revision: D12767: [Tunnelbroker] implement messages types to FCM service.Jul 16 2024, 1:23 AM

Harbormaster completed remote builds in B30361: Diff 42323.Jul 16 2024, 1:38 AM

kamil published this revision for review.Jul 16 2024, 2:38 AM

kamil edited the test plan for this revision. (Show Details)

kamil added inline comments.

services/tunnelbroker/src/notifs/fcm/token.rs
103–104 ↗	(On Diff #42323)	`FCM_ACCESS_TOKEN_GENERATION_THRESHOLD` is to handle time between this check and actual API call to send Firebase message