Page MenuHomePhabricator

[Tunnelbroker][lib] add FCM notif message type
ClosedPublic

Authored by kamil on Jul 16 2024, 1:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 2, 2:16 AM
Unknown Object (File)
Fri, Nov 1, 10:19 AM
Unknown Object (File)
Fri, Nov 1, 10:19 AM
Unknown Object (File)
Fri, Nov 1, 10:18 AM
Unknown Object (File)
Fri, Nov 1, 10:18 AM
Unknown Object (File)
Fri, Nov 1, 10:18 AM
Unknown Object (File)
Sep 25 2024, 7:04 PM
Unknown Object (File)
Sep 25 2024, 7:04 PM
Subscribers

Details

Summary

Message send from client to send notif using FCM service.

Depends on D12769

Test Plan

Tested in D12772.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Jul 16 2024, 2:45 AM
kamil added inline comments.
lib/types/tunnelbroker/notif-types.js
16

This could take only HIGH and NORMAL values but wanted to make it in-sync with Rust types

lib/types/tunnelbroker/notif-types.js
16

I'd rather make it more specific in JS, if Rust doesn't support the specificity

lib/types/tunnelbroker/notif-types.js
16

In Rust it's technically a string, but parsing will fail (or at least ignore, in D12767 it's set to None) if it's not one of the above, so I'd use +priority: 'NORMAL' | 'HIGH'. here

lib/types/tunnelbroker/notif-types.js
16

makes sense, I'll update this to +priority: 'NORMAL' | 'HIGH'. before landing

This revision is now accepted and ready to land.Jul 19 2024, 5:38 AM
This revision was landed with ongoing or failed builds.Jul 19 2024, 5:44 AM
This revision was automatically updated to reflect the committed changes.