Paths

Table of Contentst

Differential D12910

[Tunnelbroker][lib] add `BadDeviceToken` message type
ClosedPublic
Actions

Authored by kamil on Jul 29 2024, 2:17 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Dec 19, 10:39 AM

	Unknown Object (File)
	Thu, Dec 19, 10:39 AM

	Unknown Object (File)
	Thu, Dec 19, 10:39 AM

	Unknown Object (File)
	Thu, Dec 19, 10:39 AM

	Unknown Object (File)
	Thu, Dec 12, 5:05 AM

	Unknown Object (File)
	Sat, Dec 7, 12:06 PM

	Unknown Object (File)
	Sat, Dec 7, 12:00 PM

	Unknown Object (File)
	Nov 9 2024, 11:36 PM

View All 57 Files

Subscribers

Details

Reviewers

bartek
marcin
tomek

Commits

rCOMMda2cff605c4c: [Tunnelbroker][lib] add `BadDeviceToken` message type

Summary

Similar to keyserver one but for Tunnelbroker.

Depends on D12909

Test Plan

Tested later in the stack.

Diff Detail

Repository

Branch

publish-device-token

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Jul 29 2024, 2:17 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 29 2024, 2:17 AM

Harbormaster completed remote builds in B30734: Diff 42862.Jul 29 2024, 2:33 AM

kamil added a child revision: D12911: [Tunnelbroker] invalidate bad APNs tokens.Jul 29 2024, 2:53 AM

kamil published this revision for review.Jul 29 2024, 6:25 AM

kamil edited the summary of this revision. (Show Details)

kamil edited the test plan for this revision. (Show Details)

kamil added a reviewer: tomek.Jul 29 2024, 6:38 AM

bartek accepted this revision.Jul 29 2024, 8:15 AM

bartek added inline comments.

lib/types/tunnelbroker/peer-to-peer-message-types.js
115	Just curious - why do we need the invalid token value?

This revision is now accepted and ready to land.Jul 29 2024, 8:15 AM

kamil added inline comments.Jul 29 2024, 8:26 AM

lib/types/tunnelbroker/peer-to-peer-message-types.js
115	To handle some race conditions and messages delivered with delay: Tunnelbroker discovers token is invalid and queue message Device uploads a new device token (handlers trying to do it on each app load) `BadDeviceToken` is delivered. In case 3 we just ignore the message because we're invalidating a different token (implemented in D12912).

bartek added inline comments.Jul 29 2024, 12:11 PM

lib/types/tunnelbroker/peer-to-peer-message-types.js
115	Okay, this makes perfect sense to me, thanks for explaining

Closed by commit rCOMMda2cff605c4c: [Tunnelbroker][lib] add `BadDeviceToken` message type (authored by kamil). · Explain WhyJul 30 2024, 4:16 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMda2cff605c4c: [Tunnelbroker][lib] add `BadDeviceToken` message type.

Revision Contents
Changeset List

Path

Size

lib/

types/

tunnelbroker/

peer-to-peer-message-types.js

15 lines

shared/

tunnelbroker_messages/

src/

messages/

bad_device_token.rs

9 lines

4 lines

Diff 42862

lib/types/tunnelbroker/peer-to-peer-message-types.js

Loading...

shared/tunnelbroker_messages/src/messages/bad_device_token.rs

Loading...

shared/tunnelbroker_messages/src/messages/mod.rs

Loading...