Page MenuHomePhabricator
Differential D12911

[Tunnelbroker] invalidate bad APNs tokens
ClosedPublic
Actions

Authored by kamil on Jul 29 2024, 2:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 10:39 AM
Unknown Object (File)
Thu, Dec 19, 10:39 AM
Unknown Object (File)
Thu, Dec 19, 10:39 AM
Unknown Object (File)
Tue, Nov 26, 5:30 AM
Unknown Object (File)
Nov 21 2024, 1:37 AM
Unknown Object (File)
Nov 21 2024, 1:37 AM
Unknown Object (File)
Nov 21 2024, 1:37 AM
Unknown Object (File)
Nov 12 2024, 3:57 PM
View All 83 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
marcin
tomek
Commits
rCOMM041165483eb1: [Tunnelbroker] invalidate bad APNs tokens
rCOMM9c01fd2697ea: [Tunnelbroker] invalidate bad APNs tokens
Summary

ENG-8498.

Based on an error from APNs:

  1. Flip the flag in DDB.
  2. Send a message to device.

Depends on D12910

Test Plan

Manually malformed device token for iOS device in DDB, try sending notif to this device and verify that flag was flipped and the message was sent to the device (both online and offline device)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Jul 29 2024, 2:53 AM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 29 2024, 2:53 AM
kamil added a child revision: D12912: [lib] handle `BadDeviceToken` message.Jul 29 2024, 2:56 AM
Harbormaster completed remote builds in B30735: Diff 42863.Jul 29 2024, 3:10 AM
kamil published this revision for review.Jul 29 2024, 6:37 AM
kamil edited the summary of this revision. (Show Details)
kamil edited the test plan for this revision. (Show Details)
kamil added inline comments.
services/tunnelbroker/src/websockets/session.rs
406 ↗(On Diff #42863)

we should use also Unregistered and ExpiredToken (410 status code) - I did mistake while committing, going to update in next rebase

kamil added a reviewer: tomek.Jul 29 2024, 6:39 AM
kamil added a parent revision: D12920: [Tunnelbroker] add missing `ExpiredToken` error reason.Jul 29 2024, 7:37 AM
bartek accepted this revision.Jul 29 2024, 8:20 AM
bartek added inline comments.
services/tunnelbroker/src/websockets/session.rs
406 ↗(On Diff #42863)

Just FYI - this syntax should be possible:

if matches!(
  body.reason, 
  ErrorReason::BadDeviceToken | ErrorReason::Unregistered | ErrorReason::ExpiredToken
) {
This revision is now accepted and ready to land.Jul 29 2024, 8:20 AM
kamil added a child revision: D12937: [Tunnelbroker] add message to set Device Token with Platform.Jul 30 2024, 3:48 AM
Closed by commit rCOMM9c01fd2697ea: [Tunnelbroker] invalidate bad APNs tokens (authored by kamil). · Explain WhyJul 30 2024, 4:16 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM9c01fd2697ea: [Tunnelbroker] invalidate bad APNs tokens.
kamil added a reverting change: rCOMMa7a7ce7a2e5a: Revert "[Tunnelbroker] invalidate bad APNs tokens".Jul 30 2024, 4:20 AM
kamil reopened this revision.Jul 30 2024, 4:20 AM

Forgot to add missing error - sorry for that

This revision is now accepted and ready to land.Jul 30 2024, 4:20 AM
kamil updated this revision to Diff 42958.Jul 30 2024, 4:22 AM

add missing errors

This revision was landed with ongoing or failed builds.Jul 30 2024, 5:39 AM
Closed by commit rCOMM041165483eb1: [Tunnelbroker] invalidate bad APNs tokens (authored by kamil). · Explain Why
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM041165483eb1: [Tunnelbroker] invalidate bad APNs tokens.
kamil added a child revision: D12946: [Tunnelbroker] invalidate bad Web Push tokens.Jul 30 2024, 6:06 AM
Harbormaster completed remote builds in B30809: Diff 42958.Jul 30 2024, 6:20 AM

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
src/
notifs/
apns/
2 lines
websockets/
59 lines

Diff 42957

View Options

services/tunnelbroker/src/notifs/apns/mod.rs

Loading...
View Options

services/tunnelbroker/src/websockets/session.rs

Loading...