We need an oauth2 access token to supply as the bearer token when we send push notifs
Depends on D12933
Details
Details
successfully logged access token from WNS server
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Can you also test refreshing the token after expiry_window_in_secs?
| services/tunnelbroker/src/notifs/wns/mod.rs | ||
|---|---|---|
| 66–69 | can you test that case and improve it if needed? (e.g. add response.body()). I want to make sure that in case of failure, we'll log detailed errors of what went wrong | |
| services/tunnelbroker/src/notifs/wns/mod.rs | ||
|---|---|---|
| 36 | Should work. Duration::from_secs is a const fn so this is calculated once during compilation | |
| services/tunnelbroker/src/notifs/wns/mod.rs | ||
|---|---|---|
| 66–69 | tested and improved in latest revision | |