Paths

Table of Contentst

Differential D12937

[Tunnelbroker] add message to set Device Token with Platform
ClosedPublic
Actions

Authored by kamil on Jul 30 2024, 3:48 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Nov 21, 1:37 AM

	Unknown Object (File)
	Thu, Nov 21, 1:37 AM

	Unknown Object (File)
	Sun, Nov 10, 5:34 AM

	Unknown Object (File)
	Sat, Nov 9, 11:36 PM

	Unknown Object (File)
	Sat, Nov 9, 9:35 PM

	Unknown Object (File)
	Sat, Nov 9, 9:01 PM

	Unknown Object (File)
	Sat, Nov 9, 7:13 PM

	Unknown Object (File)
	Wed, Nov 6, 11:03 PM

View All 58 Files

Subscribers

Details

Reviewers

bartek
tomek

Commits

rCOMM213547da85c0: [Tunnelbroker] add message to set Device Token with Platform

Summary

Adding a new message type, we can't modify the previous because of backward compatibility - this makes it easier to achieve what we want.

Depends on D12911

Test Plan

Tests

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jul 30 2024, 3:48 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJul 30 2024, 3:48 AM

kamil edited the summary of this revision. (Show Details)Jul 30 2024, 3:50 AM

kamil added a child revision: D12938: [Tunnelbroker] add Platform column to `device_token` DDB table.Jul 30 2024, 4:04 AM

kamil published this revision for review.Jul 30 2024, 5:36 AM

Harbormaster completed remote builds in B30805: Diff 42950.Jul 30 2024, 5:48 AM

bartek added a subscriber: marcin.Jul 30 2024, 7:28 AM

bartek added inline comments.

shared/tunnelbroker_messages/src/messages/message_to_tunnelbroker.rs
12–20 ↗	(On Diff #42950)	This is useful! I guess we might want to move this enum to `comm-lib` soon, as a part of https://linear.app/comm/issue/ENG-8904/stop-sending-device-type-in-device-key-upload And use it instead of the proto enum for metadata cc @marcin
34–38 ↗	(On Diff #42950)	Do we need this trait? Isn't `Display` and `.to_string()` enough?
39–46 ↗	(On Diff #42950)	There's dedicated `FromStr` trait for this: https://doc.rust-lang.org/std/str/trait.FromStr.html

address review

shared/tunnelbroker_messages/src/messages/message_to_tunnelbroker.rs
34–38 ↗	(On Diff #42950)	It is, this some leftover
39–46 ↗	(On Diff #42950)	right

bartek accepted this revision.Jul 31 2024, 3:45 AM

This revision is now accepted and ready to land.Jul 31 2024, 3:45 AM

Harbormaster completed remote builds in B30831: Diff 42989.Jul 31 2024, 3:58 AM

Closed by commit rCOMM213547da85c0: [Tunnelbroker] add message to set Device Token with Platform (authored by kamil). · Explain WhyJul 31 2024, 7:14 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM213547da85c0: [Tunnelbroker] add message to set Device Token with Platform.

Revision Contents
Changeset List

Path

Size

lib/

types/

tunnelbroker/

message-to-tunnelbroker-types.js

9 lines

shared/

tunnelbroker_messages/

src/

messages/

message_to_tunnelbroker.rs

79 lines

Diff 42998

lib/types/tunnelbroker/message-to-tunnelbroker-types.js

Loading...

shared/tunnelbroker_messages/src/messages/message_to_tunnelbroker.rs

Loading...