[lib] Correctly handle generating ops from multiple updates
ClosedPublic
Actions

Authored by tomek on Aug 2 2024, 4:35 AM.

Details

Reviewers

kamil
inka

Commits

rCOMMb1919741e731: [lib] Correctly handle generating ops from multiple updates

Summary

We have to apply the ops from each update before generating ops for the next update.

https://linear.app/comm/issue/ENG-8932/thread-updates-are-incorrectly-reduced

Depends on D12956

Test Plan

Modified the code so that a change_thread_settings operation, that updates name, color and unread status of a thread, is processed. Made sure that the changes were correctly applied on web.

Diff Detail

Repository

rCOMM Comm

Branch

dmops

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Aug 2 2024, 4:35 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 2 2024, 4:35 AM

Harbormaster completed remote builds in B30869: Diff 43036.Aug 2 2024, 5:06 AM

tomek requested review of this revision.Aug 2 2024, 5:06 AM

inka accepted this revision.Aug 2 2024, 7:41 AM

This revision is now accepted and ready to land.Aug 2 2024, 7:41 AM

Closed by commit rCOMMb1919741e731: [lib] Correctly handle generating ops from multiple updates (authored by tomek). · Explain WhyAug 2 2024, 8:38 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMb1919741e731: [lib] Correctly handle generating ops from multiple updates.

Revision Contents
Changeset List

Path

Size

lib/

reducers/

thread-reducer.js

63 lines

Diff 43036

View Options

lib/reducers/thread-reducer.js

[lib] Correctly handle generating ops from multiple updatesClosedPublicActions