Page MenuHomePhabricator
Differential D12969

[lib] Rename editor to joiner in join thread operation
ClosedPublic
Actions

Authored by tomek on Aug 5 2024, 3:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 18 2025, 4:51 AM
Unknown Object (File)
Feb 18 2025, 4:50 AM
Unknown Object (File)
Jan 31 2025, 9:50 PM
Unknown Object (File)
Jan 29 2025, 1:26 PM
Unknown Object (File)
Jan 28 2025, 7:42 PM
Unknown Object (File)
Jan 28 2025, 7:42 PM
Unknown Object (File)
Jan 28 2025, 7:42 PM
Unknown Object (File)
Jan 15 2025, 10:44 AM
View All 79 Files
Subscribers
ashoat

Details

Reviewers
kamil
inka
Commits
rCOMMe1d01618736d: [lib] Rename editor to joiner in join thread operation
Summary

Context in https://phab.comm.dev/D12870.

Depends on D12967

Test Plan

Flow.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
shared/
dm-ops/
14 lines
types/
4 lines

Diff 43169

View Options

lib/shared/dm-ops/join-thread-spec.js

Show All 40 Lines
import { TextInput } from './modal-components.react.js'; import { TextInput } from './modal-components.react.js';
import { setNativeCredentials } from './native-credentials.js'; import { setNativeCredentials } from './native-credentials.js';
import { PanelButton, Panel } from './panel-components.react.js'; import { PanelButton, Panel } from './panel-components.react.js';
import SWMansionIcon from '../components/swmansion-icon.react.js'; import SWMansionIcon from '../components/swmansion-icon.react.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
import { nativeLogInExtraInfoSelector } from '../selectors/account-selectors.js'; import { nativeLogInExtraInfoSelector } from '../selectors/account-selectors.js';
import type { KeyPressEvent } from '../types/react-native.js'; import type { KeyPressEvent } from '../types/react-native.js';
import { AppOutOfDateAlertDetails } from '../utils/alert-messages.js'; import {
AppOutOfDateAlertDetails,
UsernameReservedAlertDetails,
UsernameTakenAlertDetails,
} from '../utils/alert-messages.js';
import Alert from '../utils/alert.js'; import Alert from '../utils/alert.js';
import { nativeNotificationsSessionCreator } from '../utils/crypto-utils.js'; import { nativeNotificationsSessionCreator } from '../utils/crypto-utils.js';
import { type StateContainer } from '../utils/state-container.js'; import { type StateContainer } from '../utils/state-container.js';
type WritableRegisterState = { type WritableRegisterState = {
usernameInputText: string, usernameInputText: string,
passwordInputText: string, passwordInputText: string,
confirmPasswordInputText: string, confirmPasswordInputText: string,
▲ Show 20 Lines • Show All 302 Lines • ▼ Show 20 Lines try {
await setNativeCredentials({ await setNativeCredentials({
username: result.currentUserInfo.username, username: result.currentUserInfo.username,
password: this.props.registerState.state.passwordInputText, password: this.props.registerState.state.passwordInputText,
}); });
return result; return result;
} catch (e) { } catch (e) {
if (e.message === 'username_reserved') { if (e.message === 'username_reserved') {
Alert.alert( Alert.alert(
'Username reserved', UsernameReservedAlertDetails.title,
'This username is currently reserved. Please contact support@' + UsernameReservedAlertDetails.message,
'comm.app if you would like to claim this account.',
[{ text: 'OK', onPress: this.onUsernameAlertAcknowledged }], [{ text: 'OK', onPress: this.onUsernameAlertAcknowledged }],
{ cancelable: false }, { cancelable: false },
); );
} else if (e.message === 'username_taken') { } else if (e.message === 'username_taken') {
Alert.alert( Alert.alert(
'Username taken', UsernameTakenAlertDetails.title,
'An account with that username already exists', UsernameTakenAlertDetails.message,
[{ text: 'OK', onPress: this.onUsernameAlertAcknowledged }], [{ text: 'OK', onPress: this.onUsernameAlertAcknowledged }],
{ cancelable: false }, { cancelable: false },
); );
} else if (e.message === 'client_version_unsupported') { } else if (e.message === 'client_version_unsupported') {
Alert.alert( Alert.alert(
AppOutOfDateAlertDetails.title, AppOutOfDateAlertDetails.title,
AppOutOfDateAlertDetails.message, AppOutOfDateAlertDetails.message,
[{ text: 'OK', onPress: this.onAppOutOfDateAlertAcknowledged }], [{ text: 'OK', onPress: this.onAppOutOfDateAlertAcknowledged }],
▲ Show 20 Lines • Show All 120 Lines • Show Last 20 Lines
View Options

lib/types/dm-ops.js

Show All 40 Lines
import { TextInput } from './modal-components.react.js'; import { TextInput } from './modal-components.react.js';
import { setNativeCredentials } from './native-credentials.js'; import { setNativeCredentials } from './native-credentials.js';
import { PanelButton, Panel } from './panel-components.react.js'; import { PanelButton, Panel } from './panel-components.react.js';
import SWMansionIcon from '../components/swmansion-icon.react.js'; import SWMansionIcon from '../components/swmansion-icon.react.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
import { nativeLogInExtraInfoSelector } from '../selectors/account-selectors.js'; import { nativeLogInExtraInfoSelector } from '../selectors/account-selectors.js';
import type { KeyPressEvent } from '../types/react-native.js'; import type { KeyPressEvent } from '../types/react-native.js';
import { AppOutOfDateAlertDetails } from '../utils/alert-messages.js'; import {
AppOutOfDateAlertDetails,
UsernameReservedAlertDetails,
UsernameTakenAlertDetails,
} from '../utils/alert-messages.js';
import Alert from '../utils/alert.js'; import Alert from '../utils/alert.js';
import { nativeNotificationsSessionCreator } from '../utils/crypto-utils.js'; import { nativeNotificationsSessionCreator } from '../utils/crypto-utils.js';
import { type StateContainer } from '../utils/state-container.js'; import { type StateContainer } from '../utils/state-container.js';
type WritableRegisterState = { type WritableRegisterState = {
usernameInputText: string, usernameInputText: string,
passwordInputText: string, passwordInputText: string,
confirmPasswordInputText: string, confirmPasswordInputText: string,
▲ Show 20 Lines • Show All 302 Lines • ▼ Show 20 Lines try {
await setNativeCredentials({ await setNativeCredentials({
username: result.currentUserInfo.username, username: result.currentUserInfo.username,
password: this.props.registerState.state.passwordInputText, password: this.props.registerState.state.passwordInputText,
}); });
return result; return result;
} catch (e) { } catch (e) {
if (e.message === 'username_reserved') { if (e.message === 'username_reserved') {
Alert.alert( Alert.alert(
'Username reserved', UsernameReservedAlertDetails.title,
'This username is currently reserved. Please contact support@' + UsernameReservedAlertDetails.message,
'comm.app if you would like to claim this account.',
[{ text: 'OK', onPress: this.onUsernameAlertAcknowledged }], [{ text: 'OK', onPress: this.onUsernameAlertAcknowledged }],
{ cancelable: false }, { cancelable: false },
); );
} else if (e.message === 'username_taken') { } else if (e.message === 'username_taken') {
Alert.alert( Alert.alert(
'Username taken', UsernameTakenAlertDetails.title,
'An account with that username already exists', UsernameTakenAlertDetails.message,
[{ text: 'OK', onPress: this.onUsernameAlertAcknowledged }], [{ text: 'OK', onPress: this.onUsernameAlertAcknowledged }],
{ cancelable: false }, { cancelable: false },
); );
} else if (e.message === 'client_version_unsupported') { } else if (e.message === 'client_version_unsupported') {
Alert.alert( Alert.alert(
AppOutOfDateAlertDetails.title, AppOutOfDateAlertDetails.title,
AppOutOfDateAlertDetails.message, AppOutOfDateAlertDetails.message,
[{ text: 'OK', onPress: this.onAppOutOfDateAlertAcknowledged }], [{ text: 'OK', onPress: this.onAppOutOfDateAlertAcknowledged }],
▲ Show 20 Lines • Show All 120 Lines • Show Last 20 Lines