Paths

Table of Contentst

[identity] Delete Backup user data on account deletion
ClosedPublic
Actions

Authored by bartek on Aug 5 2024, 4:54 AM.

Details

Reviewers

will
varun
kamil

Commits

rCOMM7d827184c069: [identity] Delete Backup user data on account deletion

Summary

Similarly to how we call Tunnelbroker, called Backup Service DELETE /user_data endpoint from D12970 to delete backup data
in DeleteUser RPCs.

Depends on D12972

Test Plan

Called the DeleteWalletUser RPC. Verified that Backup is called and user data is actually deleted from Backup DDB

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Aug 5 2024, 4:54 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 5 2024, 4:54 AM

Improve service-to-service token handling

bartek published this revision for review.Aug 5 2024, 5:35 AM

bartek added inline comments.

services/identity/src/main.rs
88–89 ↗	(On Diff #43095)	The second argument is identity service URL, but in fact, we're never going to need it, so I think it can stay hardcoded

kamil accepted this revision.Aug 5 2024, 6:10 AM

This revision is now accepted and ready to land.Aug 5 2024, 6:10 AM

This revision was landed with ongoing or failed builds.Aug 5 2024, 6:28 AM

Closed by commit rCOMM7d827184c069: [identity] Delete Backup user data on account deletion (authored by bartek). · Explain Why

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM7d827184c069: [identity] Delete Backup user data on account deletion.

Harbormaster failed remote builds in B30915: Diff 43095!Aug 5 2024, 6:45 AM

Harbormaster failed remote builds in B30910: Diff 43090!

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

backup.rs

41 lines

error.rs

2 lines

grpc_services/

authenticated.rs

17 lines

main.rs

6 lines

Diff 43126

View Options

services/identity/src/backup.rs

View Options

services/identity/src/error.rs

View Options

services/identity/src/grpc_services/authenticated.rs

View Options

services/identity/src/main.rs

[identity] Delete Backup user data on account deletionClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 43126

services/identity/src/backup.rs

services/identity/src/error.rs

services/identity/src/grpc_services/authenticated.rs

services/identity/src/main.rs

[identity] Delete Backup user data on account deletion
ClosedPublic
Actions

Revision Contents
Changeset List