[lib] Make sure we send only one join thread request at a time
ClosedPublic
Actions

Authored by tomek on Aug 6 2024, 6:49 AM.

Details

Reviewers

kamil
inka

Commits

rCOMMbfdb7208f9dc: [lib] Make sure we send only one join thread request at a time

Summary

It sometimes happens that en effect fires multiple times. This protects us against sending multiple requests to the server.

https://linear.app/comm/issue/ENG-8958/invite-invalid-when-trying-to-join-the-comm-community

Depends on D12999

Test Plan

Checked if it is still possible to join a community using invite links. Checked if accepting two invites in a row works.

Diff Detail

Repository

rCOMM Comm

Branch

master1

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Aug 6 2024, 6:49 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 6 2024, 6:49 AM

Harbormaster completed remote builds in B30959: Diff 43182.Aug 6 2024, 7:06 AM

tomek requested review of this revision.Aug 6 2024, 7:06 AM

tomek added a child revision: D13001: [lib] Properly handle server call timeout when accepting an invite link.Aug 6 2024, 7:57 AM

inka accepted this revision.Aug 6 2024, 8:08 AM

This revision is now accepted and ready to land.Aug 6 2024, 8:08 AM

Closed by commit rCOMMbfdb7208f9dc: [lib] Make sure we send only one join thread request at a time (authored by tomek). · Explain WhyAug 6 2024, 8:12 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMbfdb7208f9dc: [lib] Make sure we send only one join thread request at a time.

Revision Contents
Changeset List

Path

Size

lib/

shared/

community-utils.js

11 lines

Diff 43182

View Options

lib/shared/community-utils.js

[lib] Make sure we send only one join thread request at a timeClosedPublicActions