Page MenuHomePhabricator

[native] Use MMKV locking utils to sync between main app and notifs code
ClosedPublic

Authored by marcin on Aug 7 2024, 7:30 AM.
Tags
None
Referenced Files
F2753882: D13008.diff
Wed, Sep 18, 6:16 PM
Unknown Object (File)
Fri, Sep 6, 11:53 PM
Unknown Object (File)
Fri, Sep 6, 11:52 PM
Unknown Object (File)
Fri, Sep 6, 11:45 PM
Unknown Object (File)
Mon, Sep 2, 8:57 PM
Unknown Object (File)
Mon, Sep 2, 12:19 PM
Unknown Object (File)
Sun, Sep 1, 8:16 PM
Unknown Object (File)
Sun, Sep 1, 6:43 PM
Subscribers

Details

Summary

This differential implements synchronization that ensures encryption always wins against decryption on native notifs.

Test Plan
  1. Navigate to the top of this stack.
  2. Apply this patch: https://gist.github.com/marcinwasowicz/c89b5c944e6336a6d366895327accb51
  3. Build native app and web app.
  4. Try sending messages back and forth between both apps making.
  5. Examine the main app and the NSE logs. Main app should always persist notifs data while the NSE should sometimes fail to persist.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 7 2024, 7:53 AM
Harbormaster failed remote builds in B30980: Diff 43220!
marcin requested review of this revision.Aug 7 2024, 9:24 AM
This revision is now accepted and ready to land.Aug 13 2024, 1:42 AM
marcin edited the test plan for this revision. (Show Details)

Rebase before landing