Differential D13059
[lib] Update the replies count Authored by tomek on Aug 13 2024, 5:44 AM. Tags None Referenced Files
Subscribers
Details
https://linear.app/comm/issue/ENG-8930/unify-the-approach-to-replies-count-and-unread-status-updates Depends on D13058 Tested change thread setting and send text message operations. Verified that only send text message operation bums the replies count.
Diff Detail
Event TimelineComment Actions We tested sidebar creation and replies count is incorrect - after creating a sidebar and adding one message to it, the count was 2 instead of 1 Comment Actions Tested it a couple more times and was unable to reproduce this bug. I guess that something was wrong with the operations we were processing. const tid = uuid.v4();
await this.props.processDMOps({
type: 'create_thread',
threadID: tid,
creatorID: viewerID,
time: Date.now(),
threadType: threadTypes.LOCAL,
memberIDs: [],
roleID: uuid.v4(),
newMessageID: uuid.v4(),
});
const mid = uuid.v4();
await this.props.processDMOps({
type: 'send_text_message',
threadID: tid,
creatorID: viewerID,
time: Date.now(),
messageID: mid,
text: `${text}-parent`,
});
await sleep(100);
const sid = uuid.v4();
await this.props.processDMOps({
type: 'create_sidebar',
threadID: sid,
creatorID: viewerID,
time: Date.now(),
parentThreadID: tid,
memberIDs: [],
sourceMessageID: mid,
roleID: uuid.v4(),
newSidebarSourceMessageID: uuid.v4(),
newCreateSidebarMessageID: uuid.v4(),
});
await this.props.processDMOps({
type: 'send_text_message',
threadID: sid,
creatorID: viewerID,
time: Date.now(),
messageID: uuid.v4(),
text: `${text}-sidebar`,
}); |