Page MenuHomePhabricator
Differential D13133

[native] Rename `getAllMessages` method
ClosedPublic
Actions

Authored by tomek on Aug 21 2024, 10:13 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 28, 7:09 AM
Unknown Object (File)
Wed, Dec 18, 3:43 PM
Unknown Object (File)
Wed, Dec 18, 3:43 PM
Unknown Object (File)
Sat, Dec 14, 6:54 PM
Unknown Object (File)
Nov 25 2024, 8:01 AM
Unknown Object (File)
Nov 21 2024, 9:01 PM
Unknown Object (File)
Nov 9 2024, 12:32 PM
Unknown Object (File)
Nov 8 2024, 10:37 PM
View All 29 Files
Subscribers
ashoat

Details

Reviewers
kamil
inka
Commits
rCOMM45cdd7740bc6: [native] Rename `getAllMessages` method
Summary

The function changes in the next diff to return only a subset of messages from the thick threads.

https://linear.app/comm/issue/ENG-8699/store-only-non-pruned-messages-in-redux

Depends on D13106

Test Plan

Run the app on native and web and check if it opens correctly.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Aug 21 2024, 10:13 AM
Herald added a subscriber: ashoat. · View Herald TranscriptAug 21 2024, 10:13 AM
tomek updated this revision to Diff 43560.Aug 21 2024, 10:15 AM

Rename

Harbormaster completed remote builds in B31205: Diff 43559.Aug 21 2024, 10:34 AM
Harbormaster completed remote builds in B31206: Diff 43560.Aug 21 2024, 10:40 AM
tomek requested review of this revision.Aug 21 2024, 10:40 AM
tomek added a child revision: D13137: [native] Fetch only a subset of messages from thick threads.Aug 22 2024, 4:39 AM
kamil accepted this revision.Aug 23 2024, 8:39 AM
kamil added inline comments.
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
1487 ↗(On Diff #43560)
2792 ↗(On Diff #43560)
This revision is now accepted and ready to land.Aug 23 2024, 8:39 AM
tomek marked 2 inline comments as done.Aug 27 2024, 2:25 AM
tomek updated this revision to Diff 43666.Aug 27 2024, 2:25 AM

Update names

Harbormaster completed remote builds in B31274: Diff 43666.Aug 27 2024, 2:44 AM
Closed by commit rCOMM45cdd7740bc6: [native] Rename `getAllMessages` method (authored by tomek). · Explain WhyAug 27 2024, 8:02 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM45cdd7740bc6: [native] Rename `getAllMessages` method.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
4 lines
4 lines
29 lines
NativeModules/
2 lines
6 lines
_generated/
redux/
4 lines
2 lines
schema/
2 lines
web/
cpp/
2 lines
shared-worker/
_generated/
queries/
22 lines
types/
2 lines
worker/
2 lines

Diff 43685

View Options

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI.h

Loading...
View Options

native/redux/persist.js

Loading...
View Options

native/redux/unshim-utils.js

Loading...
View Options

native/schema/CommCoreModuleSchema.js

Loading...
View Options

web/cpp/SQLiteQueryExecutorBindings.cpp

Loading...
View Options

web/shared-worker/_generated/comm_query_executor.wasm

Loading...
View Options

web/shared-worker/queries/messages-and-media-queries.test.js

Loading...
View Options

web/shared-worker/types/sqlite-query-executor.js

Loading...
View Options

web/shared-worker/worker/process-operations.js

Loading...