Paths

Table of Contentst

Differential D13140

[web] Create a function that fetches messages in batches
ClosedPublic
Actions

Authored by tomek on Aug 22 2024, 5:19 PM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

kamil
inka

Commits

rCOMM1cee5c5f3b22: [web] Create a function that fetches messages in batches

Summary

The function uses limit and offset to get a batch of messages.

https://linear.app/comm/issue/ENG-8705/create-a-function-that-fetches-more-messages-and-dispatches-the-new

Depends on D13138

Test Plan

Tests.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Aug 22 2024, 5:19 PM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 22 2024, 5:19 PM

Harbormaster completed remote builds in B31220: Diff 43591.Aug 22 2024, 5:37 PM

tomek requested review of this revision.Aug 22 2024, 5:37 PM

tomek added a child revision: D13141: [native] Expose messages fetching function through JSI.Aug 22 2024, 5:40 PM

Extract thick thread types

Harbormaster completed remote builds in B31246: Diff 43619.Aug 23 2024, 4:26 PM

Rebase

Harbormaster completed remote builds in B31249: Diff 43622.Aug 23 2024, 4:43 PM

kamil accepted this revision.Aug 26 2024, 9:43 AM

kamil added inline comments.

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h
197–198 ↗	(On Diff #43622)	This started to be annoying, thinking how long it could take to prioritize ENG-5719 after D12736 is landed
web/shared-worker/queries/fetch-messages-queries.test.js
36 ↗	(On Diff #43622)	I would move `124` to const

This revision is now accepted and ready to land.Aug 26 2024, 9:43 AM

Extract a constant

Harbormaster completed remote builds in B31278: Diff 43670.Aug 27 2024, 11:57 AM

Closed by commit rCOMM1cee5c5f3b22: [web] Create a function that fetches messages in batches. · Explain WhyAug 27 2024, 3:02 PM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM1cee5c5f3b22: [web] Create a function that fetches messages in batches.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

DatabaseManagers/

DatabaseQueryExecutor.h

4 lines

SQLiteQueryExecutor.h

4 lines

SQLiteQueryExecutor.cpp

33 lines

web/

cpp/

SQLiteQueryExecutorBindings.cpp

3 lines

shared-worker/

_generated/

comm_query_executor.wasm

queries/

fetch-messages-queries.test.js

109 lines

types/

1 line

sqlite-query-executor.js

7 lines

Diff 43689

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

Loading...

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

Loading...

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...

web/cpp/SQLiteQueryExecutorBindings.cpp

Loading...

web/shared-worker/_generated/comm_query_executor.wasm

Loading...

web/shared-worker/queries/fetch-messages-queries.test.js

Loading...

web/shared-worker/types/entities.js

Loading...

web/shared-worker/types/sqlite-query-executor.js

Loading...