Page MenuHomePhabricator
Differential D13140

[web] Create a function that fetches messages in batches
ClosedPublic
Actions

Authored by tomek on Aug 22 2024, 10:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 8, 5:10 PM
Unknown Object (File)
Sat, Mar 8, 5:10 PM
Unknown Object (File)
Wed, Mar 5, 6:09 AM
Unknown Object (File)
Feb 7 2025, 3:14 PM
Unknown Object (File)
Jan 30 2025, 2:55 PM
Unknown Object (File)
Jan 19 2025, 5:52 PM
Unknown Object (File)
Jan 16 2025, 8:04 PM
Unknown Object (File)
Jan 15 2025, 11:10 AM
View All 45 Files
Subscribers
ashoat

Details

Reviewers
kamil
inka
Commits
rCOMM1cee5c5f3b22: [web] Create a function that fetches messages in batches
Summary

The function uses limit and offset to get a batch of messages.

https://linear.app/comm/issue/ENG-8705/create-a-function-that-fetches-more-messages-and-dispatches-the-new

Depends on D13138

Test Plan

Tests.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Aug 22 2024, 10:19 AM
Herald added a subscriber: ashoat. · View Herald TranscriptAug 22 2024, 10:19 AM
Harbormaster completed remote builds in B31220: Diff 43591.Aug 22 2024, 10:37 AM
tomek requested review of this revision.Aug 22 2024, 10:37 AM
tomek added a child revision: D13141: [native] Expose messages fetching function through JSI.Aug 22 2024, 10:40 AM
tomek updated this revision to Diff 43619.EditedAug 23 2024, 9:09 AM

Extract thick thread types

Harbormaster completed remote builds in B31246: Diff 43619.Aug 23 2024, 9:26 AM
tomek updated this revision to Diff 43622.Aug 23 2024, 9:26 AM

Rebase

Harbormaster completed remote builds in B31249: Diff 43622.Aug 23 2024, 9:43 AM
kamil accepted this revision.Aug 26 2024, 2:43 AM
kamil added inline comments.
native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h
197–198 ↗(On Diff #43622)

This started to be annoying, thinking how long it could take to prioritize ENG-5719 after D12736 is landed

web/shared-worker/queries/fetch-messages-queries.test.js
36 ↗(On Diff #43622)

I would move 124 to const

This revision is now accepted and ready to land.Aug 26 2024, 2:43 AM
tomek updated this revision to Diff 43670.Aug 27 2024, 4:40 AM

Extract a constant

Harbormaster completed remote builds in B31278: Diff 43670.Aug 27 2024, 4:57 AM
Closed by commit rCOMM1cee5c5f3b22: [web] Create a function that fetches messages in batches (authored by tomek). · Explain WhyAug 27 2024, 8:02 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM1cee5c5f3b22: [web] Create a function that fetches messages in batches.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
4 lines
4 lines
33 lines
web/
cpp/
3 lines
shared-worker/
_generated/
queries/
109 lines
types/
1 line
7 lines

Diff 43689

View Options

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

fn main() { fn main() {
tonic_build::compile_protos("../../shared/protos/identity.proto") tonic_build::compile_protos("../../shared/protos/identity.proto")
.unwrap_or_else(|e| panic!("Failed to compile protos {:?}", e)); .unwrap_or_else(|e| panic!("Failed to compile identity protos {:?}", e));
tonic_build::compile_protos("../../shared/protos/blob.proto")
.unwrap_or_else(|e| panic!("Failed to compile blob protos {:?}", e));
let _cxx_build = let _cxx_build =
cxx_build::bridge("src/lib.rs").flag_if_supported("-std=c++14"); cxx_build::bridge("src/lib.rs").flag_if_supported("-std=c++14");
println!("cargo:rerun-if-changed=src/hello.c"); println!("cargo:rerun-if-changed=src/hello.c");
} }
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

fn main() { fn main() {
tonic_build::compile_protos("../../shared/protos/identity.proto") tonic_build::compile_protos("../../shared/protos/identity.proto")
.unwrap_or_else(|e| panic!("Failed to compile protos {:?}", e)); .unwrap_or_else(|e| panic!("Failed to compile identity protos {:?}", e));
tonic_build::compile_protos("../../shared/protos/blob.proto")
.unwrap_or_else(|e| panic!("Failed to compile blob protos {:?}", e));
let _cxx_build = let _cxx_build =
cxx_build::bridge("src/lib.rs").flag_if_supported("-std=c++14"); cxx_build::bridge("src/lib.rs").flag_if_supported("-std=c++14");
println!("cargo:rerun-if-changed=src/hello.c"); println!("cargo:rerun-if-changed=src/hello.c");
} }
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

fn main() { fn main() {
tonic_build::compile_protos("../../shared/protos/identity.proto") tonic_build::compile_protos("../../shared/protos/identity.proto")
.unwrap_or_else(|e| panic!("Failed to compile protos {:?}", e)); .unwrap_or_else(|e| panic!("Failed to compile identity protos {:?}", e));
tonic_build::compile_protos("../../shared/protos/blob.proto")
.unwrap_or_else(|e| panic!("Failed to compile blob protos {:?}", e));
let _cxx_build = let _cxx_build =
cxx_build::bridge("src/lib.rs").flag_if_supported("-std=c++14"); cxx_build::bridge("src/lib.rs").flag_if_supported("-std=c++14");
println!("cargo:rerun-if-changed=src/hello.c"); println!("cargo:rerun-if-changed=src/hello.c");
} }
View Options

web/cpp/SQLiteQueryExecutorBindings.cpp

fn main() { fn main() {
tonic_build::compile_protos("../../shared/protos/identity.proto") tonic_build::compile_protos("../../shared/protos/identity.proto")
.unwrap_or_else(|e| panic!("Failed to compile protos {:?}", e)); .unwrap_or_else(|e| panic!("Failed to compile identity protos {:?}", e));
tonic_build::compile_protos("../../shared/protos/blob.proto")
.unwrap_or_else(|e| panic!("Failed to compile blob protos {:?}", e));
let _cxx_build = let _cxx_build =
cxx_build::bridge("src/lib.rs").flag_if_supported("-std=c++14"); cxx_build::bridge("src/lib.rs").flag_if_supported("-std=c++14");
println!("cargo:rerun-if-changed=src/hello.c"); println!("cargo:rerun-if-changed=src/hello.c");
} }
View Options

web/shared-worker/_generated/comm_query_executor.wasm

fn main() { fn main() {
tonic_build::compile_protos("../../shared/protos/identity.proto") tonic_build::compile_protos("../../shared/protos/identity.proto")
.unwrap_or_else(|e| panic!("Failed to compile protos {:?}", e)); .unwrap_or_else(|e| panic!("Failed to compile identity protos {:?}", e));
tonic_build::compile_protos("../../shared/protos/blob.proto")
.unwrap_or_else(|e| panic!("Failed to compile blob protos {:?}", e));
let _cxx_build = let _cxx_build =
cxx_build::bridge("src/lib.rs").flag_if_supported("-std=c++14"); cxx_build::bridge("src/lib.rs").flag_if_supported("-std=c++14");
println!("cargo:rerun-if-changed=src/hello.c"); println!("cargo:rerun-if-changed=src/hello.c");
} }
View Options

web/shared-worker/queries/fetch-messages-queries.test.js

Loading...
View Options

web/shared-worker/types/entities.js

Loading...
View Options

web/shared-worker/types/sqlite-query-executor.js

Loading...