Paths

Table of Contentst

Differential D13140

[web] Create a function that fetches messages in batches
ClosedPublic
Actions

Authored by tomek on Aug 22 2024, 10:19 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Oct 23, 8:21 AM

	Unknown Object (File)
	Wed, Oct 23, 4:17 AM

	Unknown Object (File)
	Tue, Oct 22, 9:43 PM

	Unknown Object (File)
	Tue, Oct 22, 8:33 AM

	Unknown Object (File)
	Thu, Oct 17, 1:56 PM

	Unknown Object (File)
	Tue, Oct 15, 1:13 AM

	Unknown Object (File)
	Mon, Oct 14, 4:09 PM

	Unknown Object (File)
	Sep 26 2024, 9:47 PM

View All 26 Files

Subscribers

Details

Reviewers

kamil
inka

Commits

rCOMM1cee5c5f3b22: [web] Create a function that fetches messages in batches

Summary

The function uses limit and offset to get a batch of messages.

https://linear.app/comm/issue/ENG-8705/create-a-function-that-fetches-more-messages-and-dispatches-the-new

Depends on D13138

Test Plan

Tests.

Diff Detail

Repository

Branch

messages-pruning

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Aug 22 2024, 10:19 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 22 2024, 10:19 AM

Harbormaster completed remote builds in B31220: Diff 43591.Aug 22 2024, 10:37 AM

tomek requested review of this revision.Aug 22 2024, 10:37 AM

tomek added a child revision: D13141: [native] Expose messages fetching function through JSI.Aug 22 2024, 10:40 AM

Extract thick thread types

Harbormaster completed remote builds in B31246: Diff 43619.Aug 23 2024, 9:26 AM

Rebase

Harbormaster completed remote builds in B31249: Diff 43622.Aug 23 2024, 9:43 AM

kamil accepted this revision.Aug 26 2024, 2:43 AM

kamil added inline comments.

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h
197–198 ↗	(On Diff #43622)	This started to be annoying, thinking how long it could take to prioritize ENG-5719 after D12736 is landed
web/shared-worker/queries/fetch-messages-queries.test.js
36 ↗	(On Diff #43622)	I would move `124` to const

This revision is now accepted and ready to land.Aug 26 2024, 2:43 AM

Extract a constant

Harbormaster completed remote builds in B31278: Diff 43670.Aug 27 2024, 4:57 AM

Closed by commit rCOMM1cee5c5f3b22: [web] Create a function that fetches messages in batches (authored by tomek). · Explain WhyAug 27 2024, 8:02 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM1cee5c5f3b22: [web] Create a function that fetches messages in batches.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

DatabaseManagers/

DatabaseQueryExecutor.h

4 lines

SQLiteQueryExecutor.h

4 lines

SQLiteQueryExecutor.cpp

33 lines

web/

cpp/

SQLiteQueryExecutorBindings.cpp

6 lines

shared-worker/

_generated/

comm_query_executor.wasm

queries/

fetch-messages-queries.test.js

108 lines

types/

1 line

sqlite-query-executor.js

7 lines

Diff 43591

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

Loading...

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

Loading...

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...

web/cpp/SQLiteQueryExecutorBindings.cpp

Loading...

web/shared-worker/_generated/comm_query_executor.wasm

Loading...

web/shared-worker/queries/fetch-messages-queries.test.js

Loading...

web/shared-worker/types/entities.js

Loading...

web/shared-worker/types/sqlite-query-executor.js

Loading...