Details

Reviewers

kamil
inka

Commits

rCOMM695c02284c8f: [web] Extract a function that creates web messages

Summary

This logic was repeated, and I need to use it in the next diff.

Depends on D13137

Test Plan

Tests.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Aug 22 2024, 4:17 PM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 22 2024, 4:17 PM

Rename

Harbormaster completed remote builds in B31215: Diff 43573.Aug 22 2024, 4:34 PM

Rebase

Harbormaster failed remote builds in B31216: Diff 43582!Aug 22 2024, 4:40 PM

Harbormaster completed remote builds in B31218: Diff 43584.Aug 22 2024, 4:54 PM

tomek requested review of this revision.Aug 22 2024, 4:54 PM

tomek added a child revision: D13140: [web] Create a function that fetches messages in batches.Aug 22 2024, 5:19 PM

Rebase

Harbormaster completed remote builds in B31248: Diff 43621.Aug 23 2024, 4:39 PM

kamil accepted this revision.Aug 26 2024, 9:14 AM

kamil added inline comments.

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h
207–208 ↗	(On Diff #43621)	I would move this to line 45 to make this private

This revision is now accepted and ready to land.Aug 26 2024, 9:14 AM

Make the method private

Harbormaster completed remote builds in B31276: Diff 43668.Aug 27 2024, 10:49 AM

Remove the method from DatabaseQueryExecutor

Harbormaster completed remote builds in B31277: Diff 43669.Aug 27 2024, 11:53 AM

Closed by commit rCOMM695c02284c8f: [web] Extract a function that creates web messages. · Explain WhyAug 27 2024, 3:02 PM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM695c02284c8f: [web] Extract a function that creates web messages.

[web] Extract a function that creates web messages
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 43687

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

web/shared-worker/_generated/comm_query_executor.wasm

[web] Extract a function that creates web messagesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 43687

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

web/shared-worker/_generated/comm_query_executor.wasm

[web] Extract a function that creates web messages
ClosedPublic
Actions

Revision Contents
Changeset List