Differential D13227

[tunnelbroker] Close WS session when received special AMQP message
ClosedPublic
Actions

Authored by bartek on Sep 2 2024, 11:46 PM.

Details

Reviewers

kamil

Commits

rCOMM407963823a72: [tunnelbroker] Close WS session when received special AMQP message

Summary

Address ENG-8256.

Added a special AMQP message, that when received by consumer for given device ID, the websocket session is closed.

Test Plan

Modified SendMessageToDevice to send this message instead. Confirmed that the device is disconnected.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Sep 2 2024, 11:46 PM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 2 2024, 11:46 PM

bartek added a child revision: D13228: [tunnelbroker] Add RPC for closing WebSocket sessions.Sep 2 2024, 11:49 PM

Harbormaster completed remote builds in B31403: Diff 43849.Sep 3 2024, 12:02 AM

I also considered using an enum

enum AMQPMessage {
  MessageToDevice(MessageToDevice),
  SessionClose
}

but again I had weird issues with serde when trying to make it backwards compatible with existing format.

For now I sticked to simple "special message" constant.

One note: This is safe because of serialization here and the malicious device will not be able to close other devices sessions.

This revision is now accepted and ready to land.Sep 6 2024, 6:08 AM

Closed by commit rCOMM407963823a72: [tunnelbroker] Close WS session when received special AMQP message (authored by bartek). · Explain WhySep 9 2024, 6:15 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM407963823a72: [tunnelbroker] Close WS session when received special AMQP message.

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

src/

constants.rs

1 line

websockets/

mod.rs

9 lines

Diff 43982

View Options

services/tunnelbroker/src/constants.rs