[tunnelbroker] Add RPC for closing WebSocket sessions
ClosedPublic
Actions

Authored by bartek on Sep 2 2024, 11:49 PM.

Details

Reviewers

kamil
ashoat

Commits

rCOMM1146dc9cfddf: [tunnelbroker] Add RPC for closing WebSocket sessions

Summary

Address ENG-8217.

Added Tunnelbroker RPC that force-closes WebSocket session with given device ID (if present).
The message is not persisted - it makes no point of storing it if the device isn't connected to Tunnelbroker at the time.

Depends on D13227

Test Plan

Repeated test plan from D13227, now by calling the RPC

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Sep 2 2024, 11:49 PM

bartek held this revision as a draft.

Herald added a subscriber: tomek. · View Herald TranscriptSep 2 2024, 11:49 PM

bartek added a child revision: D13229: [identity] Ask Tunnelbroker to terminate old device sessions.Sep 2 2024, 11:52 PM

Harbormaster completed remote builds in B31404: Diff 43850.Sep 3 2024, 12:04 AM

bartek published this revision for review.Sep 3 2024, 12:13 AM

bartek added inline comments.

services/tunnelbroker/src/grpc/mod.rs
91–95 ↗	(On Diff #43850)	Also noticed in the docs: Setting the TTL to 0 causes messages to be expired upon reaching a queue unless they can be delivered to a consumer immediately. Thus this provides an alternative to the immediate publishing flag, which the RabbitMQ server does not support. I considered this but decided to give it a short timeout (1000ms), just in case.

This is meant to be called by other services, right? After ENG-9129 is resolved, it should only be possible to access from other services?

ashoat accepted this revision.Sep 4 2024, 11:22 PM

In D13228#373308, @ashoat wrote:

This is meant to be called by other services, right? After ENG-9129 is resolved, it should only be possible to access from other services?

Yes, this is right. Only services should be able to call it (namely Identity)

kamil accepted this revision.Sep 6 2024, 6:10 AM

This revision is now accepted and ready to land.Sep 6 2024, 6:10 AM

Closed by commit rCOMM1146dc9cfddf: [tunnelbroker] Add RPC for closing WebSocket sessions (authored by bartek). · Explain WhySep 9 2024, 6:15 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM1146dc9cfddf: [tunnelbroker] Add RPC for closing WebSocket sessions.