Page MenuHomePhabricator
Differential D13269

[identity] Replace handle_db_error mapping with question mark
ClosedPublic
Actions

Authored by bartek on Sep 9 2024, 6:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 15, 4:05 AM
Unknown Object (File)
Sun, Mar 9, 9:55 AM
Unknown Object (File)
Thu, Mar 6, 5:49 AM
Unknown Object (File)
Wed, Mar 5, 10:04 PM
Unknown Object (File)
Wed, Mar 5, 1:50 PM
Unknown Object (File)
Wed, Feb 26, 11:38 AM
Unknown Object (File)
Wed, Feb 26, 11:38 AM
Unknown Object (File)
Wed, Feb 26, 11:37 AM
View All 54 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
Commits
rCOMMad4441eb9c2b: [identity] Replace handle_db_error mapping with question mark
Summary

Follow up https://phab.comm.dev/D13226?id=43848#inline-76241

Depends on D13226

Test Plan

Cargo check

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
services/
identity/
src/
221 lines
grpc_services/
149 lines

Diff 44136

View Options

services/identity/src/client_service.rs

Show First 20 Lines • Show All 122 Lines • ▼ Show 20 Lines const mediaID =
request.type === 'image' || request.type === 'encrypted_image' request.type === 'image' || request.type === 'encrypted_image'
? request.uploadID ? request.uploadID
: null; : null;
const query = SQL` const query = SQL`
START TRANSACTION; START TRANSACTION;
UPDATE uploads UPDATE uploads
SET container = NULL SET user_container = NULL
WHERE uploader = ${viewer.userID} WHERE uploader = ${viewer.userID}
AND container = ${viewer.userID} AND user_container = ${viewer.userID}
AND ( AND (
${mediaID} IS NULL ${mediaID} IS NULL
OR EXISTS ( OR EXISTS (
SELECT 1 SELECT 1
FROM uploads FROM uploads
WHERE id = ${mediaID} WHERE id = ${mediaID}
AND uploader = ${viewer.userID} AND uploader = ${viewer.userID}
AND container IS NULL AND container IS NULL
AND user_container IS NULL
AND thread IS NULL AND thread IS NULL
) )
); );
UPDATE uploads UPDATE uploads
SET container = ${viewer.userID} SET user_container = ${viewer.userID}
WHERE id = ${mediaID} WHERE id = ${mediaID}
AND uploader = ${viewer.userID} AND uploader = ${viewer.userID}
AND container IS NULL AND container IS NULL
AND user_container IS NULL
AND thread IS NULL; AND thread IS NULL;
UPDATE users UPDATE users
SET avatar = ${newAvatarValue} SET avatar = ${newAvatarValue}
WHERE id = ${viewer.userID} WHERE id = ${viewer.userID}
AND ( AND (
${mediaID} IS NULL ${mediaID} IS NULL
OR EXISTS ( OR EXISTS (
SELECT 1 SELECT 1
FROM uploads FROM uploads
WHERE id = ${mediaID} WHERE id = ${mediaID}
AND uploader = ${viewer.userID} AND uploader = ${viewer.userID}
AND container = ${viewer.userID} AND user_container = ${viewer.userID}
AND thread IS NULL AND thread IS NULL
) )
); );
COMMIT; COMMIT;
SELECT id AS upload_id, secret AS upload_secret, extra AS upload_extra SELECT id AS upload_id, secret AS upload_secret, extra AS upload_extra
FROM uploads FROM uploads
WHERE id = ${mediaID} WHERE id = ${mediaID}
AND uploader = ${viewer.userID} AND uploader = ${viewer.userID}
AND container = ${viewer.userID}; AND user_container = ${viewer.userID};
`; `;
const [resultSet] = await dbQuery(query, { multipleStatements: true }); const [resultSet] = await dbQuery(query, { multipleStatements: true });
const selectResult = resultSet.pop(); const selectResult = resultSet.pop();
const knownUserInfos: UserInfos = await fetchKnownUserInfos(viewer); const knownUserInfos: UserInfos = await fetchKnownUserInfos(viewer);
const updates: CreateUpdatesResult = await createUserAvatarUpdates( const updates: CreateUpdatesResult = await createUserAvatarUpdates(
viewer, viewer,
▲ Show 20 Lines • Show All 71 Lines • Show Last 20 Lines
View Options

services/identity/src/grpc_services/authenticated.rs

Show First 20 Lines • Show All 122 Lines • ▼ Show 20 Lines const mediaID =
request.type === 'image' || request.type === 'encrypted_image' request.type === 'image' || request.type === 'encrypted_image'
? request.uploadID ? request.uploadID
: null; : null;
const query = SQL` const query = SQL`
START TRANSACTION; START TRANSACTION;
UPDATE uploads UPDATE uploads
SET container = NULL SET user_container = NULL
WHERE uploader = ${viewer.userID} WHERE uploader = ${viewer.userID}
AND container = ${viewer.userID} AND user_container = ${viewer.userID}
AND ( AND (
${mediaID} IS NULL ${mediaID} IS NULL
OR EXISTS ( OR EXISTS (
SELECT 1 SELECT 1
FROM uploads FROM uploads
WHERE id = ${mediaID} WHERE id = ${mediaID}
AND uploader = ${viewer.userID} AND uploader = ${viewer.userID}
AND container IS NULL AND container IS NULL
AND user_container IS NULL
AND thread IS NULL AND thread IS NULL
) )
); );
UPDATE uploads UPDATE uploads
SET container = ${viewer.userID} SET user_container = ${viewer.userID}
WHERE id = ${mediaID} WHERE id = ${mediaID}
AND uploader = ${viewer.userID} AND uploader = ${viewer.userID}
AND container IS NULL AND container IS NULL
AND user_container IS NULL
AND thread IS NULL; AND thread IS NULL;
UPDATE users UPDATE users
SET avatar = ${newAvatarValue} SET avatar = ${newAvatarValue}
WHERE id = ${viewer.userID} WHERE id = ${viewer.userID}
AND ( AND (
${mediaID} IS NULL ${mediaID} IS NULL
OR EXISTS ( OR EXISTS (
SELECT 1 SELECT 1
FROM uploads FROM uploads
WHERE id = ${mediaID} WHERE id = ${mediaID}
AND uploader = ${viewer.userID} AND uploader = ${viewer.userID}
AND container = ${viewer.userID} AND user_container = ${viewer.userID}
AND thread IS NULL AND thread IS NULL
) )
); );
COMMIT; COMMIT;
SELECT id AS upload_id, secret AS upload_secret, extra AS upload_extra SELECT id AS upload_id, secret AS upload_secret, extra AS upload_extra
FROM uploads FROM uploads
WHERE id = ${mediaID} WHERE id = ${mediaID}
AND uploader = ${viewer.userID} AND uploader = ${viewer.userID}
AND container = ${viewer.userID}; AND user_container = ${viewer.userID};
`; `;
const [resultSet] = await dbQuery(query, { multipleStatements: true }); const [resultSet] = await dbQuery(query, { multipleStatements: true });
const selectResult = resultSet.pop(); const selectResult = resultSet.pop();
const knownUserInfos: UserInfos = await fetchKnownUserInfos(viewer); const knownUserInfos: UserInfos = await fetchKnownUserInfos(viewer);
const updates: CreateUpdatesResult = await createUserAvatarUpdates( const updates: CreateUpdatesResult = await createUserAvatarUpdates(
viewer, viewer,
▲ Show 20 Lines • Show All 71 Lines • Show Last 20 Lines