Page MenuHomePhabricator

Implement maunally marking DM thread as read/unread
ClosedPublic

Authored by marcin on Sep 4 2024, 5:28 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 22, 6:30 PM
Unknown Object (File)
Tue, Oct 22, 6:29 PM
Unknown Object (File)
Sun, Oct 20, 7:46 PM
Unknown Object (File)
Sun, Oct 20, 7:46 PM
Unknown Object (File)
Sun, Oct 20, 7:46 PM
Unknown Object (File)
Sun, Oct 20, 7:46 PM
Unknown Object (File)
Sun, Oct 20, 7:58 AM
Unknown Object (File)
Fri, Oct 18, 11:36 PM
Subscribers

Details

Summary

This differential implements marking dm thread as read/unread manually (by toggle).

Test Plan

Play around marking a thread as read/unrad on one device and ensure that changes are reflected in the UI of another device (if app is active) or result in correct badge updates/rescinds (inactive app)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

marcin requested review of this revision.Sep 4 2024, 6:16 AM
tomek added inline comments.
lib/hooks/toggle-unread-status.js
10–11 ↗(On Diff #43881)

Can be merged.

This revision is now accepted and ready to land.Sep 6 2024, 8:21 AM
This revision was landed with ongoing or failed builds.Sep 9 2024, 9:06 AM
This revision was automatically updated to reflect the committed changes.

I have the same concerns here that I highlighted in D13260. @marcin, can you address them as part of the same stack as D13260, and land the fixes together?