Page MenuHomePhabricator
Differential D13238

Implement maunally marking DM thread as read/unread
ClosedPublic
Actions

Authored by marcin on Sep 4 2024, 5:28 AM.
Tags
None
Referenced Files
F3008414: D13238.id43969.diff
Fri, Oct 18, 9:37 PM
F3008410: D13238.id43997.diff
Fri, Oct 18, 9:36 PM
Unknown Object (File)
Sat, Oct 12, 5:36 AM
Unknown Object (File)
Thu, Oct 10, 1:10 PM
Unknown Object (File)
Thu, Oct 3, 9:50 AM
Unknown Object (File)
Wed, Oct 2, 2:48 AM
Unknown Object (File)
Fri, Sep 27, 11:30 AM
Unknown Object (File)
Fri, Sep 27, 8:29 AM
View All 50 Files
Subscribers
ashoat

Details

Reviewers
tomek
kamil
Commits
rCOMMaf90fa403c02: Implement maunally marking DM thread as read/unread
Summary

This differential implements marking dm thread as read/unread manually (by toggle).

Test Plan

Play around marking a thread as read/unrad on one device and ensure that changes are reflected in the UI of another device (if app is active) or result in correct badge updates/rescinds (inactive app)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Sep 4 2024, 5:28 AM
Herald added a subscriber: ashoat. · View Herald TranscriptSep 4 2024, 5:28 AM
Harbormaster completed remote builds in B31426: Diff 43881.Sep 4 2024, 6:16 AM
marcin requested review of this revision.Sep 4 2024, 6:16 AM
marcin added a child revision: D13246: Implement DMActivityHandler.Sep 5 2024, 6:16 AM
tomek accepted this revision.Sep 6 2024, 8:21 AM
tomek added inline comments.
lib/hooks/toggle-unread-status.js
10–11 ↗(On Diff #43881)

Can be merged.

This revision is now accepted and ready to land.Sep 6 2024, 8:21 AM
marcin updated this revision to Diff 43969.Sep 9 2024, 3:07 AM

Move dm logic to hook

Harbormaster completed remote builds in B31485: Diff 43969.Sep 9 2024, 3:25 AM
marcin updated this revision to Diff 43993.Sep 9 2024, 7:25 AM

Rebase

Harbormaster completed remote builds in B31500: Diff 43993.Sep 9 2024, 7:41 AM
marcin updated this revision to Diff 43997.Sep 9 2024, 8:56 AM

Rebase before landing

This revision was landed with ongoing or failed builds.Sep 9 2024, 9:06 AM
Closed by commit rCOMMaf90fa403c02: Implement maunally marking DM thread as read/unread (authored by marcin). · Explain Why
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMMaf90fa403c02: Implement maunally marking DM thread as read/unread.
Harbormaster completed remote builds in B31502: Diff 43997.Sep 9 2024, 9:12 AM
ashoat added a comment.Sep 9 2024, 2:13 PM

I have the same concerns here that I highlighted in D13260. @marcin, can you address them as part of the same stack as D13260, and land the fixes together?

Revision Contents
Changeset List

PathSize
lib/
actions/
53 lines
hooks/
6 lines

Diff 43969

View Options

lib/actions/activity-actions.js

Loading...
View Options

lib/hooks/toggle-unread-status.js

Loading...