Page MenuHomePhabricator

[comm-lib] Let BlobServiceClient accept service-to-service token
ClosedPublic

Authored by bartek on Fri, Sep 13, 2:28 AM.
Tags
None
Referenced Files
F2763404: D13318.id44171.diff
Thu, Sep 19, 10:59 AM
F2761176: D13318.id.diff
Thu, Sep 19, 7:34 AM
F2753609: D13318.id44170.diff
Wed, Sep 18, 5:57 PM
Unknown Object (File)
Wed, Sep 18, 9:37 AM
Unknown Object (File)
Wed, Sep 18, 4:49 AM
Unknown Object (File)
Wed, Sep 18, 12:19 AM
Unknown Object (File)
Tue, Sep 17, 1:50 PM
Unknown Object (File)
Tue, Sep 17, 1:05 PM
Subscribers

Details

Summary

Updated BlobServiceClient to accept service-to-service token requests. This means HTTP services that rely on this Blob client, can accept service-to-service token and pass it through to Blob Service.

In short, previously:

  • client -[CSAT]-> backup -[S2SToken]-> blob was possible
  • identity -[S2SToken]-> backup -[S2SToken]-> blob wasn't possible

This diff makes the latter possible too, by overriding the accepts_services_token() for BlobServiceClient.

Test Plan

Ran Backup and Blob locally, supplied Backup request with service-to-service token instead of CSAT, made sure the COMM_SERVICES_DISABLE_CSAT_VERIFICATION is disabled. Request succeeded.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable