[web] Remove admins tab when there are no admins
ClosedPublic
Actions

Authored by tomek on Sep 17 2024, 2:27 AM.

Details

Reviewers

kamil
will

Commits

rCOMMab389ba6796c: [web] Remove admins tab when there are no admins

Summary

In thick threads there are no admins, so it doesn't make sense to show an empty tab. Instead of hiding the tab just for thick threads, we can hide the tab every time there are no admins.

https://linear.app/comm/issue/ENG-9258/remove-admins-tab-in-thick-threads

Test Plan

Open a members menu in a thread with some admins and check if both tabs appear. Open it in a thick thread and check if only the members tab is present.

Diff Detail

Repository

rCOMM Comm

Branch

improvements2

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Sep 17 2024, 2:27 AM

tomek retitled this revision from [web] Remove admins tab when there are. no admins to [web] Remove admins tab when there are no admins.Sep 17 2024, 2:27 AM

tomek edited reviewers, added: will; removed: bartek, ashoat.

tomek edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B31660: Diff 44263.Sep 17 2024, 2:44 AM

tomek requested review of this revision.Sep 17 2024, 2:44 AM

will accepted this revision.Sep 17 2024, 9:53 AM

This revision is now accepted and ready to land.Sep 17 2024, 9:53 AM

Closed by commit rCOMMab389ba6796c: [web] Remove admins tab when there are no admins (authored by tomek). · Explain WhySep 18 2024, 7:03 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMab389ba6796c: [web] Remove admins tab when there are no admins.