Paths

Table of Contentst

Differential D13371

[lib] refactor `createOlmSessionWithPeer` -> `createOlmSessionsWithUser`
ClosedPublic
Actions

Authored by kamil on Sep 18 2024, 11:51 AM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

bartek
tomek
marcin

Commits

rCOMMa9f48d77d6a5: [lib] refactor `createOlmSessionWithPeer` -> `createOlmSessionsWithUser`

Summary

This API better matches Identity API, which returns data for all user devices.

Additionally, session creation for each device is done in parallel.

Test Plan

Tested in D13376

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Sep 18 2024, 11:51 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptSep 18 2024, 11:51 AM

kamil edited the summary of this revision. (Show Details)Sep 18 2024, 11:52 AM

kamil added inline comments.Sep 18 2024, 11:56 AM

lib/utils/crypto-utils.js
184	This change is a fix for ENG-9278. We shouldn't throw it as this is a regular case: having singleton device list having an out-of-sync device list in auxUserStore (e.g. device on logout failed to send updates) - created ENG-9332 to track.

kamil added a child revision: D13372: [lib] refactor `createOlmSessionWithPeer` -> `createOlmSessionsWithUser` in `PeerOlmSessionCreatorContextType`.Sep 18 2024, 12:01 PM

Harbormaster completed remote builds in B31679: Diff 44289.Sep 18 2024, 12:08 PM

kamil published this revision for review.Sep 18 2024, 12:42 PM

kamil edited the test plan for this revision. (Show Details)

ashoat added inline comments.Sep 18 2024, 1:01 PM

lib/components/peer-olm-session-creator-provider.react.js
13–16	It's weird that this is defined here but `SessionCreationOptions` is defined above `createOlmSessionsWithUser` Would it make sense to move this definition to be closer to `SessionCreationOptions`?

tomek accepted this revision.Sep 18 2024, 2:21 PM

This revision is now accepted and ready to land.Sep 18 2024, 2:21 PM

tomek added inline comments.Sep 18 2024, 2:23 PM

lib/utils/crypto-utils.js
243–247	It might be a good idea to also log an exception

bartek accepted this revision.Sep 18 2024, 6:53 PM

log exception
move type definition to a better place

Harbormaster completed remote builds in B31706: Diff 44322.Sep 19 2024, 8:44 AM

Closed by commit rCOMMa9f48d77d6a5: [lib] refactor `createOlmSessionWithPeer` -> `createOlmSessionsWithUser`. · Explain WhySep 19 2024, 10:49 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMa9f48d77d6a5: [lib] refactor `createOlmSessionWithPeer` -> `createOlmSessionsWithUser`.

Revision Contents
Changeset List

Path

Size

lib/

components/

peer-olm-session-creator-provider.react.js

12 lines

utils/

crypto-utils.js

192 lines

Diff 44289

lib/components/peer-olm-session-creator-provider.react.js

Loading...

lib/utils/crypto-utils.js

Loading...