Details
Details
- Test sending messages when session not exists.
- Test sending when session exists.
- Make sure notifs still works.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Paths
| Differential D13376 Authored by kamil on Sep 18 2024, 5:15 AM.
Details Summary Test Plan
Diff Detail
Event Timelinekamil held this revision as a draft. Herald added a subscriber: ashoat. · View Herald TranscriptSep 18 2024, 5:15 AM2024-09-18 05:15:52 (UTC-7) Harbormaster completed remote builds in B31684: Diff 44294.Sep 18 2024, 5:32 AM2024-09-18 05:32:42 (UTC-7) kamil mentioned this in D13371: [lib] refactor `createOlmSessionWithPeer` -> `createOlmSessionsWithUser`.Sep 18 2024, 5:42 AM2024-09-18 05:42:04 (UTC-7) kamil mentioned this in D13372: [lib] refactor `createOlmSessionWithPeer` -> `createOlmSessionsWithUser` in `PeerOlmSessionCreatorContextType`. tomek added inline comments. This revision is now accepted and ready to land.Sep 18 2024, 10:55 PM2024-09-18 22:55:53 (UTC-7) Harbormaster completed remote builds in B31711: Diff 44328.Sep 19 2024, 3:46 AM2024-09-19 03:46:47 (UTC-7) Closed by commit rCOMMd1a5df1d074a: [lib] refactor sending `OutboundP2PMessages` to peers (authored by kamil). · Explain WhySep 19 2024, 3:49 AM2024-09-19 03:49:42 (UTC-7) This revision was automatically updated to reflect the committed changes. kamil mentioned this in rCOMM41c7da0e74f0: [lib] refactor `createOlmSessionWithPeer` -> `createOlmSessionsWithUser` in…. kamil mentioned this in rCOMMa9f48d77d6a5: [lib] refactor `createOlmSessionWithPeer` -> `createOlmSessionsWithUser`. kamil mentioned this in rCOMM829c23c21d48: [lib] refactor notif code to support creating session with multiple devices of…. kamil mentioned this in rCOMM3aca795e8ca2: [lib] refactor methods from `PeerToPeerContext` to utils.
Revision Contents
Diff 44335 lib/tunnelbroker/peer-to-peer-context.js
|
This is because of Flow not being able to infer these as non-null after await broadcastAccountDeletion(); was called