Page MenuHomePhabricator
Differential D13385

[lib] remove `outboundP2PMessages` for devices removed from device list
ClosedPublic
Actions

Authored by kamil on Sep 18 2024, 9:07 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 25, 7:16 PM
Unknown Object (File)
Sat, Jan 25, 7:16 PM
Unknown Object (File)
Sat, Jan 25, 7:16 PM
Unknown Object (File)
Sat, Jan 25, 7:16 PM
Unknown Object (File)
Sat, Jan 25, 7:16 PM
Unknown Object (File)
Jan 5 2025, 4:18 AM
Unknown Object (File)
Dec 25 2024, 4:53 PM
Unknown Object (File)
Dec 25 2024, 4:53 PM
View All 59 Files
Subscribers
ashoat

Details

Reviewers
tomek
bartek
Commits
rCOMMd2363bcedd18: [lib] remove `outboundP2PMessages` for devices removed from device list
Summary

Fix for ENG-9336.

Test Plan

Test case described in ENG-9336

Diff Detail

Repository
rCOMM Comm
Branch
publish-fixes
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Sep 18 2024, 9:07 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptSep 18 2024, 9:07 AM
kamil published this revision for review.Sep 18 2024, 9:09 AM
Harbormaster completed remote builds in B31703: Diff 44318.Sep 18 2024, 9:25 AM
tomek requested changes to this revision.Sep 18 2024, 9:41 AM

It might be a better idea to clear the messages when a device is removed from the device list.

Also, we should clear auto-retriable messages that aren't scheduled using this queue.

This revision now requires changes to proceed.Sep 18 2024, 9:41 AM
kamil updated this revision to Diff 44338.Sep 19 2024, 4:13 AM

remove auto-retriable messages too

kamil added a comment.Sep 19 2024, 4:14 AM
In D13385#376821, @tomek wrote:

It might be a better idea to clear the messages when a device is removed from the device list.

Created ENG-9338 to track.

Also, we should clear auto-retriable messages that aren't scheduled using this queue.

Addressed

Harbormaster completed remote builds in B31714: Diff 44338.Sep 19 2024, 4:30 AM
tomek accepted this revision.Sep 20 2024, 2:23 AM
This revision is now accepted and ready to land.Sep 20 2024, 2:23 AM
bartek accepted this revision.Sep 20 2024, 4:45 AM
Closed by commit rCOMMd2363bcedd18: [lib] remove `outboundP2PMessages` for devices removed from device list (authored by kamil). · Explain WhySep 20 2024, 7:16 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMd2363bcedd18: [lib] remove `outboundP2PMessages` for devices removed from device list.

Revision Contents
Changeset List

PathSize
lib/
handlers/
24 lines

Diff 44318

View Options

lib/handlers/db-ops-handler.react.js

Loading...