This differential creates large notifications in thick threads
Details
Details
- Reviewers
kamil tomek - Commits
- rCOMM51312a1e05f8: Create large notifications in thick threads
Tested in final diff
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- marcin/eng-8709
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
It's quite a large diff adding support for large notifs - I think it would be a lot easier to review it if it was split into multiple smaller ones. We don't have the time to split it, but overall the diff makes sense to me.
| lib/push/send-utils.js | ||
|---|---|---|
| 505 ↗ | (On Diff #44563) | Can this be readonly? |
| 793 ↗ | (On Diff #44563) | |
| 816 ↗ | (On Diff #44563) | Why is it inexact? |
| lib/push/send-utils.js | ||
|---|---|---|
| 505 ↗ | (On Diff #44563) | I must have forgotten to update this diff. This code is no longer there |
| 793 ↗ | (On Diff #44563) | It is not going to work with eslint since largeNotifDataArray is already declared in the upper scope |
| 816 ↗ | (On Diff #44563) | buildNotifsForPlatform expects a function that returns {
+targetedNotificationsWithPlatform: $ReadOnlyArray<TargetedNotificationWithPlatform>,
+largeNotifDataArray?: ...
}but function that create badge updates and rescinds return only targetedNotificationsWithPlatform. Making the type here inexact solves flow complaint. |